From 1912cb6d92a1744eb34da72fa9b4ceeab529ab69 Mon Sep 17 00:00:00 2001
From: maleksandrov <marin.aleksandrov25@gmail.com>
Date: Wed, 14 Apr 2021 22:43:55 +0300
Subject: [PATCH 1/3] Dropdown with user roles and saving

---
 src/components/EditUser.vue | 11 ++++++++---
 src/i18n/en-us/index.js     |  3 ++-
 src/store/users/state.js    | 15 +++++++++++++++
 3 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/src/components/EditUser.vue b/src/components/EditUser.vue
index da5f92f4..e48fd263 100644
--- a/src/components/EditUser.vue
+++ b/src/components/EditUser.vue
@@ -50,9 +50,9 @@
                     <q-icon :name="isPwd ? 'visibility_off' : 'visibility'" class="cursor-pointer" @click="isPwd = !isPwd" />
                   </template>
                 </q-input>
+                <q-select outlined v-model="level" :options="permissions" :label="this.$t('user_permissions')" emit-value map-options></q-select>
 
-                <!--<q-select
-                  outlined
+                <!--outlined
                   :options="languages"
                   :label="this.$t('select_language')"
                   option-value="value"
@@ -122,6 +122,9 @@ export default {
     create() {
       return this.$store.state.users.create
     },
+    permissions() {
+      return this.$store.state.users.permissions
+    },
     /* languages() {
       return this.$store.state.app.languages
     }, */
@@ -137,6 +140,7 @@ export default {
       email: null,
       username: null,
       password: '',
+      level: null,
       totp: null,
       isPwd: true,
       actions: false,
@@ -163,6 +167,7 @@ export default {
       this.email = newdata.email
       this.username = newdata.username
       this.password = newdata.password
+      this.level = newdata.level
       // this.settingsLanguage = newdata.settings.language
       this.multifactorEnabled = newdata.multifactorEnabled
     },
@@ -245,7 +250,7 @@ export default {
       const media = new FormData()
       if (this.email !== null) formData.email = this.email
       if (this.password !== '') formData.password = this.password
-
+      if (this.level !== null) formData.level = this.level
       // Settings
       formData.settings = {}
       if (this.settingsLanguage !== null) formData.settings.language = this.settingsLanguage.value
diff --git a/src/i18n/en-us/index.js b/src/i18n/en-us/index.js
index 15db3afc..d4241f7a 100644
--- a/src/i18n/en-us/index.js
+++ b/src/i18n/en-us/index.js
@@ -125,5 +125,6 @@ export default {
   invalid_input_url: 'Please provide a full URL including protocol, such as https://',
   miscellaneous_settings: 'Miscellaneous Settings',
   miscellaneous_settings_more: 'Settings related to opening tabs',
-  link_open: 'Links open in'
+  link_open: 'Links open in',
+  user_permissions: 'User permissions'
 }
diff --git a/src/store/users/state.js b/src/store/users/state.js
index fe31a2bb..1fce330c 100644
--- a/src/store/users/state.js
+++ b/src/store/users/state.js
@@ -2,6 +2,21 @@ export default function () {
   return {
     all: [],
     create: false,
+    level: null,
+    permissions: [
+      {
+        label: 'Admin',
+        value: 0
+      },
+      {
+        label: 'Normal User',
+        value: 1
+      },
+      {
+        label: 'Read Only',
+        value: 2
+      }
+    ],
     edit: {
       id: null,
       avatar: null,

From 44acdb705717264b43cb8358a03075ef5e8ec046 Mon Sep 17 00:00:00 2001
From: maleksandrov <marin.aleksandrov25@gmail.com>
Date: Fri, 16 Apr 2021 20:01:28 +0300
Subject: [PATCH 2/3] Initial permissions support on backend/frontend

---
 models/user.js              |  5 +---
 routes/index.js             | 22 +++++++++++++----
 routes/items.js             |  6 ++---
 routes/users.js             | 47 +++++++++++++++++++++++++------------
 src/components/EditUser.vue | 19 +++++++++++----
 src/components/MenuList.vue |  2 +-
 src/i18n/en-us/index.js     |  6 ++++-
 src/layouts/User.vue        |  2 +-
 src/store/users/actions.js  |  3 +--
 9 files changed, 77 insertions(+), 35 deletions(-)

diff --git a/models/user.js b/models/user.js
index 3e1a1c48..c52bd864 100644
--- a/models/user.js
+++ b/models/user.js
@@ -17,10 +17,7 @@ class User extends Model {
         email: DataTypes.STRING,
         avatar: DataTypes.STRING,
         password: {
-          type: DataTypes.STRING,
-          set(val) {
-            this.setDataValue('password', bcrypt.hashSync(val, 10))
-          }
+          type: DataTypes.STRING
         },
         settings: {
           type: DataTypes.TEXT,
diff --git a/routes/index.js b/routes/index.js
index 9444387c..dbc4d0a8 100644
--- a/routes/index.js
+++ b/routes/index.js
@@ -41,12 +41,26 @@ router.post(
       }
     })
 
-    if (req.body.username && req.body.password) {
-      if (!user || !user.verifyPassword(req.body.password)) {
+    if (!user) {
+      return res.status(403).json({
+        status: 'error',
+        result: 'Invalid username or password!'
+      })
+    }
+
+    if (user.password !== null) {
+      if (req.body.password === null || req.body.password === '' || !req.body.password) {
         return res.status(403).json({
           status: 'error',
-          result: 'invalid_user'
+          result: 'Invalid username or password!'
         })
+      } else {
+        if (!user.verifyPassword(req.body.password)) {
+          return res.status(403).json({
+            status: 'error',
+            result: 'Invalid username or password!'
+          })
+        }
       }
     }
 
@@ -89,7 +103,7 @@ router.post(
 )
 
 /**
- * Login endpoint
+ * Logout endpoint
  */
 router.get(
   '/logout',
diff --git a/routes/items.js b/routes/items.js
index 392f11eb..5f1e57dc 100644
--- a/routes/items.js
+++ b/routes/items.js
@@ -55,7 +55,7 @@ router.get(
 router.post(
   '/',
   errorHandler(async (req, res, next) => {
-    if (!req.user) {
+    if (!req.user || req.user.level === User.READ_ONLY) {
       return res.status(401).json({
         status: 'error',
         result: 'unauthorized'
@@ -121,7 +121,7 @@ router.post(
 router.put(
   '/:id',
   errorHandler(async (req, res, next) => {
-    if (!req.user) {
+    if (!req.user || req.user.level === User.READ_ONLY) {
       return res.status(401).json({
         status: 'error',
         result: 'unauthorized'
@@ -203,7 +203,7 @@ router.put(
 router.delete(
   '/:id',
   errorHandler(async (req, res, next) => {
-    if (!req.user) {
+    if (!req.user || req.user.level === User.READ_ONLY) {
       return res.status(401).json({
         status: 'error',
         result: 'unauthorized'
diff --git a/routes/users.js b/routes/users.js
index 68270cb4..7c35c152 100644
--- a/routes/users.js
+++ b/routes/users.js
@@ -1,6 +1,7 @@
 const express = require('express')
 const router = express.Router()
 const { User, Setting } = require('../models/index')
+const bcrypt = require('bcrypt')
 const _ = require('lodash')
 const Speakeasy = require('speakeasy')
 const QRCode = require('qrcode')
@@ -71,7 +72,7 @@ router.post(
         result: 'unauthorized'
       })
     }
-
+    //Only admins can create users
     if (usersCount > 0 && req.user.level !== User.ADMIN) {
       delete req.body.level
     }
@@ -88,8 +89,20 @@ router.post(
         result: 'username_exists'
       })
     }
+    let pass = null
+    if (req.body.password) {
+      pass = bcrypt.hashSync(req.body.password, 10)
+    } else {
+      pass = null
+    }
 
-    const user = await User.create(req.body)
+    const user = await User.create({
+      username: req.body.username,
+      password: pass,
+      email: req.body.email,
+      level: req.body.level,
+      settings: req.body.settings
+    })
 
     return res.json({
       status: 'ok',
@@ -117,7 +130,7 @@ router.put(
     }
 
     // only admins can edit other users
-    if (req.user.id !== req.params.id && req.user.level !== User.ADMIN) {
+    if (req.user.id.toString() !== req.params.id && req.user.level !== User.ADMIN) {
       return res.status(401).json({
         status: 'error',
         result: 'unauthorized'
@@ -130,15 +143,19 @@ router.put(
       }
     })
 
-    if (req.body.currentPassword) {
-      if (!user.verifyPassword(req.body.currentPassword)) {
-        return res.status(400).json({
-          status: 'error',
-          result: 'incorrect_password'
+    if (req.body.updatePass) {
+      if (req.body.password) {
+        let pass = bcrypt.hashSync(req.body.password, 10)
+        user.update({
+          password: pass
+        })
+      } else {
+        user.update({
+          password: null
         })
       }
-    } else {
-      // If we didn't pass up the current password, don't submit a new password
+      delete req.body.password
+    } else if (!req.body.updatePass) {
       delete req.body.password
     }
 
@@ -158,7 +175,6 @@ router.put(
         label: user.username
       })
       const qrcode = await QRCode.toDataURL(url, { scale: 6 })
-
       user.update({
         totpSecret: secret.base32
       })
@@ -177,7 +193,9 @@ router.put(
           window: 0
         })
       ) {
-        user.update({ multifactorEnabled: true })
+        user.update({
+          multifactorEnabled: true
+        })
 
         return res.json({
           status: 'ok'
@@ -196,7 +214,6 @@ router.put(
 
       return res.json({ status: 'ok' })
     }
-
     await user.update(req.body)
 
     return res.json({
@@ -219,8 +236,8 @@ router.put(
       })
     }
 
-    // only admins can edit other users
-    if (req.user.id !== req.params.id && req.user.level !== User.ADMIN) {
+    // users can only change their avatar
+    if (req.user.id.toString() !== req.params.id && req.user.level !== User.ADMIN) {
       return res.status(401).json({
         status: 'error',
         result: 'unauthorized'
diff --git a/src/components/EditUser.vue b/src/components/EditUser.vue
index e48fd263..c3cd97a8 100644
--- a/src/components/EditUser.vue
+++ b/src/components/EditUser.vue
@@ -45,12 +45,17 @@
 
                 <q-input outlined v-model="email" :label="this.$t('email')"></q-input>
 
-                <q-input v-model="password" :label="this.$t('password')" outlined :type="isPwd ? 'password' : 'text'">
+                <q-input :disable="!updatePass" v-model="password" :label="this.$t('password')" outlined :type="isPwd ? 'password' : 'text'">
                   <template v-slot:append>
                     <q-icon :name="isPwd ? 'visibility_off' : 'visibility'" class="cursor-pointer" @click="isPwd = !isPwd" />
                   </template>
                 </q-input>
-                <q-select outlined v-model="level" :options="permissions" :label="this.$t('user_permissions')" emit-value map-options></q-select>
+                <div class="q-mb-md">
+                  <q-checkbox v-model="updatePass" :label="user.id ? $t('update_pass') : this.$t('create_pass')" @click="updatePass = !updatePass">
+                    <q-tooltip content-style="font-size: 15px" max-width="360px" :offset="[10, 10]">{{ user.id ? $t('update_pass_tooltip') : $t('create_pass_tooltip') }}</q-tooltip>
+                  </q-checkbox>
+                </div>
+                <q-select v-if="currentUser.level === 0" outlined v-model="level" :options="permissions" :label="this.$t('user_permissions')" emit-value map-options></q-select>
 
                 <!--outlined
                   :options="languages"
@@ -116,6 +121,9 @@ export default {
   components: {},
 
   computed: {
+    currentUser() {
+      return this.$store.state.app.user
+    },
     user() {
       return this.$store.state.users.edit
     },
@@ -143,6 +151,7 @@ export default {
       level: null,
       totp: null,
       isPwd: true,
+      updatePass: false,
       actions: false,
       multifactorEnabled: false,
       qrcode: null,
@@ -151,7 +160,7 @@ export default {
       changeavatar: false,
       settingtab: 'general',
       settingsLanguage: null,
-      urlvatar: '',
+      urlavatar: '',
       mfacode: null,
       mfalinks: {
         link1: '<a href="https://support.google.com/accounts/answer/1066447">Google Authenticator</a>',
@@ -249,8 +258,9 @@ export default {
       }
       const media = new FormData()
       if (this.email !== null) formData.email = this.email
-      if (this.password !== '') formData.password = this.password
+      if (this.updatePass !== false) formData.password = this.password
       if (this.level !== null) formData.level = this.level
+      formData.updatePass = this.updatePass
       // Settings
       formData.settings = {}
       if (this.settingsLanguage !== null) formData.settings.language = this.settingsLanguage.value
@@ -268,6 +278,7 @@ export default {
         await this.$store.dispatch('users/save', data)
         await this.$store.dispatch('users/getUsers')
         await this.$store.dispatch('app/status')
+        await this.$store.dispatch('users/clear')
         this.$store.commit('users/edit', this.$store.state.app.user)
         this.$store.commit('users/create', false)
         this.$q.notify({
diff --git a/src/components/MenuList.vue b/src/components/MenuList.vue
index fb8c977b..744d5dfe 100644
--- a/src/components/MenuList.vue
+++ b/src/components/MenuList.vue
@@ -24,7 +24,7 @@
       <q-tab-panels v-model="activetab" animated>
         <q-tab-panel name="user">
           <EssentialLink :title="this.$t('dashboard')" :caption="this.tiles + ' ' + this.$tc('app', this.tiles)" icon="dashboard" link="/" />
-          <EssentialLink :title="this.$tc('application')" :caption="this.active_tiles + ' ' + this.$tc('app', this.active_tiles)" icon="apps" link="/account" />
+          <EssentialLink v-if="user.level !== 2" :title="this.$tc('application')" :caption="this.active_tiles + ' ' + this.$tc('app', this.active_tiles)" icon="apps" link="/account" />
           <EssentialLink :title="this.$t('settings')" icon="settings" link="/account/settings" />
         </q-tab-panel>
 
diff --git a/src/i18n/en-us/index.js b/src/i18n/en-us/index.js
index d4241f7a..65c72b10 100644
--- a/src/i18n/en-us/index.js
+++ b/src/i18n/en-us/index.js
@@ -126,5 +126,9 @@ export default {
   miscellaneous_settings: 'Miscellaneous Settings',
   miscellaneous_settings_more: 'Settings related to opening tabs',
   link_open: 'Links open in',
-  user_permissions: 'User permissions'
+  user_permissions: 'User permissions',
+  update_pass: 'Update password?',
+  update_pass_tooltip: 'If you want to update the password, tick the box and fill the desired password (For NO password, leave password blank)',
+  create_pass: 'Create password?',
+  create_pass_tooltip: 'If you want password tick the box and fill the desired password, else dont tick the box'
 }
diff --git a/src/layouts/User.vue b/src/layouts/User.vue
index 96072c71..94334b94 100644
--- a/src/layouts/User.vue
+++ b/src/layouts/User.vue
@@ -1,5 +1,5 @@
 <template>
-  <q-layout v-if="user.level === 0" view="lHh Lpr lFf">
+  <q-layout view="lHh Lpr lFf">
     <q-header class="bg-grey-1 text-grey-7" bordered>
       <q-toolbar>
         <q-btn flat dense round @click="leftDrawerOpen = !leftDrawerOpen" icon="menu" aria-label="Menu" />
diff --git a/src/store/users/actions.js b/src/store/users/actions.js
index 1f20b9e2..cc58e0c9 100644
--- a/src/store/users/actions.js
+++ b/src/store/users/actions.js
@@ -20,10 +20,9 @@ export function saveUser(context, data) {
 export async function save(context, data) {
   if (data.id === null) {
     const user = await axios.post(process.env.BACKEND_LOCATION + 'users', data.user)
-    console.log(user)
     let media = null
     if (data.media) {
-      media = await axios.put(process.env.BACKEND_LOCATION + 'users/' + user.data.id + '/avatar', data.media)
+      media = await axios.put(process.env.BACKEND_LOCATION + 'users/' + user.data.result.id + '/avatar', data.media)
     }
     return {
       user: user,

From f1eacb454776ca079c137a21ac1c50638fea382c Mon Sep 17 00:00:00 2001
From: maleksandrov <marin.aleksandrov25@gmail.com>
Date: Wed, 21 Apr 2021 10:07:26 +0300
Subject: [PATCH 3/3] PR required fixes

---
 routes/users.js     | 2 --
 tests/tests.test.js | 3 ++-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/routes/users.js b/routes/users.js
index 7c35c152..3f7634cb 100644
--- a/routes/users.js
+++ b/routes/users.js
@@ -92,8 +92,6 @@ router.post(
     let pass = null
     if (req.body.password) {
       pass = bcrypt.hashSync(req.body.password, 10)
-    } else {
-      pass = null
     }
 
     const user = await User.create({
diff --git a/tests/tests.test.js b/tests/tests.test.js
index 260a0816..e1ee316b 100644
--- a/tests/tests.test.js
+++ b/tests/tests.test.js
@@ -1,4 +1,5 @@
 const { User, Item } = require('../models/index')
+const bcrypt = require('bcrypt')
 
 beforeAll(async () => {
   await User.destroy({ where: {} })
@@ -8,7 +9,7 @@ test('Creates a user', async () => {
   const user = await User.create({
     username: 'admin',
     email: 'admin@example.com',
-    password: 'admin'
+    password: bcrypt.hashSync('admin', 10)
   })
 
   expect(user.username).toBe('admin')