Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add another versioning support #89

Closed
1 task done
zewelor opened this issue Jul 2, 2024 · 8 comments
Closed
1 task done

[FEAT] Add another versioning support #89

zewelor opened this issue Jul 2, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@zewelor
Copy link

zewelor commented Jul 2, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

I think it would be good to add new versioning docker tag support, like: "9.7_p1-r3"

Reason for change

Currently there is tag called "version-" but its not supported by renovate bot by default. Other images seems to have this kind of versioning scheme:

https://github.com/linuxserver/docker-healthchecks/pkgs/container/healthchecks ( 3.4.20240701 )
https://github.com/linuxserver/docker-mariadb/pkgs/container/mariadb ( 10.11.8 )

Proposed code change

No response

@zewelor zewelor added the enhancement New feature or request label Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@aptalca aptalca closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Jul 2, 2024
@Roxedus
Copy link
Member

Roxedus commented Jul 2, 2024

The upstream version is not something we can parse safely to anything but 9.7_p1-r3 https://pkgs.alpinelinux.org/packages?name=*openssh-server-pam*&branch=v3.20 thus the current tagging scheme.

@zewelor
Copy link
Author

zewelor commented Jul 2, 2024

Hi

thanks for quick response. Maybe it would be good to have tag for example "9.7_p1-r3" as alternative to current "version-9.7_p1-r3" ?

@Roxedus
Copy link
Member

Roxedus commented Jul 2, 2024

It would not. configure renovate properly against our tagging if you want to use it.

@aptalca
Copy link
Member

aptalca commented Jul 2, 2024

3rd sentence from my link above:
Utilizes logic to determine if upstream is using SemVer, and if determined not, this tag is not pushed

@mbrodala
Copy link

mbrodala commented Jul 3, 2024

Here is what we use now in our renovate.json BTW:

  "packageRules": [
    {
      "matchPackageNames": ["ghcr.io/linuxserver/openssh-server"],
      "versioning": "regex:^(?<major>\\d+)\\.(?<minor>\\d+)_p(?<patch>\\d+)-(?<build>r\\d)-(?<revision>.+)$"
    }
  ]

Maybe not 100% correct but at least Renovate now suggests updates.

@zewelor
Copy link
Author

zewelor commented Jul 3, 2024

Thanks for sharing ! I've wanted to use version- tag and i ended up with something similar in the end:

    {
      matchPackageNames: [
        "ghcr.io/linuxserver/openssh-server"
      ],
      versioning: "regex:^version-(?<major>\\d+)\\.(?<minor>\\d+)_p(?<patch>\\d+)-r(?<build>\\d+)$"
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants