Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Documentation fix #16

Closed
1 task done
salamander2 opened this issue Mar 26, 2024 · 5 comments
Closed
1 task done

[FEAT] Documentation fix #16

salamander2 opened this issue Mar 26, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@salamander2
Copy link

salamander2 commented Mar 26, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Your documentation does not say whether your mysql-workbench image includes MySQL or not. There's literally not one sentence that clarifies this. You could say one of the following:

  • "This image comes with mysql built in"
  • "This image has MariaDB version x,y.z installed"
  • "This image does NOT include MySQL, however we do kindly provide instructions for how to connect your MySQL container to this one".

Please add a docker-compose.yml that shows how to connect MySQL-workbench to MySQL server. (Assuming that it is not already included.)

Thanks.
(Note: I have not yet downloaded it and tried it out to see exactly what the status is. I'll do that this evening. I'm just astonished about this omission in the documentation.)

Reason for change

Clarity. Need I say more?

Proposed code change

fixed up docker-compose.yml

@salamander2 salamander2 added the enhancement New feature or request label Mar 26, 2024
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@salamander2 salamander2 changed the title [FEAT] <title> [FEAT] Documentation fix Mar 26, 2024
@j0nnymoe
Copy link
Member

Mysql-workbench is a separate product to mysql, much like it is advertised on mysql's website itself.

It's a tool to run SQL queries against MySQL/MariaDB servers much like Microsoft's SQL Management Studio.

There is no need to add adjust the compose to show how to deploy/connect to a MySQL server with this product because it's a desktop application (within a kasmvnc instance) which you would then add your connection details to for your various servers.

I would suggest attempting to deploy the container first before asking for clarity/changes so you can see what the application is / how it works.

@j0nnymoe j0nnymoe closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Mar 26, 2024
@Roxedus
Copy link
Member

Roxedus commented Mar 26, 2024

mysql-workbench as a application does not bundle mysql, that fact should make it clear if it is included in the image

@aptalca
Copy link
Member

aptalca commented Mar 26, 2024

The image has mysql-workbench. Nothing more, nothing less. The description in the image links to the website of the product, which explains what it is.

Don't get astonished if a potato peeler doesn't say whether it comes with potatoes or not. It's a potato peeler, that's all. You provide your own potatoes.

@salamander2
Copy link
Author

salamander2 commented Mar 28, 2024

FYI.
For anyone who is looking for how to connect this MySQL-WorkBench container to MYSQL, here's the information you need.

docker-compose.yml

services:
  workbench:
    image: linuxserver/mysql-workbench:latest
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=America/Toronto
    volumes:
      - "./wbData:/config"
    ports:
      - 3000:3000
      - 3001:3001
    cap_add:
      - IPC_LOCK
    #restart: unless-stopped

  sqldb:
    image: mysql:8.0.36-debian
    environment:
      MYSQL_ROOT_PASSWORD: devstack
      TZ: America/Toronto
    ports:
      - 3306:3306
    #restart: unless-stopped
    volumes:
      - "./sqlData:/var/lib/mysql"

✏️ NOTE: the most recent MySQL version is not supported.

💥 And the critical part: Once you start MySQL-Workbench (ie. browsing to localhost:3000), you need to setup the database connection. HOWEVER "localhost:3306" does not wok. You have to use the container name "sqldb:3306"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants