Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #11 #12

Closed
wants to merge 4 commits into from
Closed

Fix for #11 #12

wants to merge 4 commits into from

Conversation

TheTumultuousUnicornOfDarkness
Copy link
Collaborator

Hello,

This is a concrete proposal about #11 (comment).
I did some tests to fix #11, and with these changes, EOG successfully opens when started by Czkawka AppImage.

@TheTumultuousUnicornOfDarkness
Remove LD_LIBRARY_PATH export
e166060 
No more required since ee988ad
@TheTumultuousUnicornOfDarkness
Add a script to run executables outside AppImage
0fef54c 
Some programs crash due to environment variables override
Fix #11
@TheTumultuousUnicornOfDarkness
Fix search_tool function
863f59b 
Full path is mandatory to allow test like '-x' to work when 'command -v' successes
Also, there is no need to 'exit 1' on failure: tests are already done outside this function
@TheTumultuousUnicornOfDarkness
Use uppercase word for warning messages
df4668d 
linuxdeploy uses uppercase, it makes it more homogeneous
@TheAssassin
Copy link
Member

You've found exactly why using $LD_LIBRARY_PATH is not a good idea. Same goes for any environment variable. The moment an external application needs to be run, it'll break.

The solution you proposed is basically a bad hack. Many other tools, e.g., AppImageBuilder, and some KDE thing, rather preload a library with LD_PRELOAD which resets the environment variables. The advantage is that this is way more reliable than exclude-listing a bunch of binaries. Perhaps linuxdeploy should build such a tool, too, that could then be included?

@TheAssassin
Copy link
Member

References:

@TheTumultuousUnicornOfDarkness
Copy link
Collaborator Author

Ok, I understand.
appimage-exec-wrapper seems to be a part of https://github.com/AppImageCrafters/AppRun now.

But Czkawka is written in Rust, and there is no exec() or something like that in this case. I have no knowledge in Rust, so I have no idea what linuxdeploy should intercept.

Merged
@TheAssassin TheAssassin mentioned this pull request Jan 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAssassin TheAssassin Awaiting requested review from TheAssassin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open images after recent commits
2 participants
@TheTumultuousUnicornOfDarkness @TheAssassin