Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/qt5integration #38

Closed
wants to merge 1 commit into from

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#230

Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#230
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • ChameleonMovementAnimation类中,setTargetRect方法没有正确更新m_currentRect的值。
  • drawMenuItemBackground方法中,动画对象animation的检查逻辑可能存在问题,因为animation可能是nullptr
  • drawMenuItemBackground方法中,使用painter->setOpacity时,应该检查painter是否为nullptr
  • drawMenuItem方法中,useHighlightedText变量的使用可能会导致逻辑错误,因为它依赖于animation的状态,但animation是在drawMenuItemBackground方法中获取的。
  • progress方法的实现可能不正确,因为它返回的是currentLoopTime除以duration的结果,这可能不是预期的行为。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 10, 2024

TAG Bot

New tag: 6.0.18
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #37

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #47

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 31, 2024

TAG Bot

New tag: 6.0.21
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #53

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 15, 2024

TAG Bot

New tag: 6.0.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #55

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 22, 2024

TAG Bot

New tag: 6.0.23
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #57

@kegechen kegechen closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants