Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [mainwidow] The software page is not fully displayed #1045

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Kakueeen
Copy link
Contributor

@Kakueeen Kakueeen commented Jan 6, 2025

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. WidgetInfo结构体中,createDWidgetFunc函数指针的声明和定义之间有一个多余的空行,建议删除以保持代码整洁。
  2. getDWidget函数中,createDWidgetFunc的调用前后应该有适当的空行,以提高代码的可读性。
  3. Controller::registerWidgetCreator函数中,if语句的条件判断应该使用大括号,即使只有一行代码,以避免将来添加代码时出现错误。
  4. Controller::showRightspace函数中,connect语句的lambda表达式参数列表中有多余的空格,建议删除以保持一致性。
  5. Controller::initMainWindow函数中,if语句的条件判断应该使用大括号,即使只有一行代码,以保持代码风格的一致性。
  6. Controller::initMainWindow函数中,if语句的条件判断应该使用大括号,即使只有一行代码,以保持代码风格的一致性。
  7. Controller::initMainWindow函数中,if语句的条件判断应该使用大括号,即使只有一行代码,以保持代码风格的一致性。

总体来说,代码的修改提高了代码的可读性和一致性,但还有一些细节需要进一步注意。

Copy link

github-actions bot commented Jan 6, 2025

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "src/plugins/core/uicontroller/controller.cpp": [
        {
            "line": "        QDesktopServices::openUrl(QUrl(\"https://github.com/linuxdeepin/deepin-unioncode/issues\"));",
            "line_number": 1201,
            "rule": "S35",
            "reason": "Url link | f8f0d2a7c7"
        },
        {
            "line": "        QDesktopServices::openUrl(QUrl(\"https://uosdn.uniontech.com/#document2?dirid=656d40a9bd766615b0b02e5e\"));",
            "line_number": 1208,
            "rule": "S35",
            "reason": "Url link | f9197a3d4e"
        }
    ]
}

@deepin-mozart deepin-mozart merged commit 5f7068a into linuxdeepin:master Jan 7, 2025
9 of 10 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, Kakueeen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants