Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复【画板】转换为ddf格式的图片无法打开 #88

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented May 9, 2024

修复【画板】转换为ddf格式的图片无法打开

Bug: https://pms.uniontech.com/bug-view-253321.html
Log: 修复【画板】转换为ddf格式的图片无法打开

修复【画板】转换为ddf格式的图片无法打开

Bug: https://pms.uniontech.com/bug-view-253321.html
Log: 修复【画板】转换为ddf格式的图片无法打开
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MainWindow::initConnection函数中新增的_Exit(0);可能会导致程序异常退出,需要确认这是否是预期行为。
  • 检查drawBoard()->close()返回值的具体含义,以确保调用_Exit(0);时能够正确处理。

是否建议立即修改:

  • 是,需要确认新增的_Exit(0);是否符合程序的退出逻辑,并确保其返回值被正确处理。如果这不是预期的行为,应该立即进行修改。

@starhcq
Copy link
Contributor

starhcq commented May 9, 2024

[是否满足兼容性要求] y
[是否满足commit提交规范] y
[是否满足编码规范] y
[review结论] pass
[fail原因] n/a

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link
Contributor Author

myk1343 commented May 9, 2024

/merge

@deepin-bot deepin-bot bot merged commit 53e6659 into linuxdeepin:master May 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants