Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复卸载驱动会弹出未发现该驱动模块错误 #330

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jeffshuai
Copy link

修复部分设备sysfs的设备设置驱动信息

Log: 修复部分设备卸载驱动时问题

Bug: https://pms.uniontech.com/bug-view-262223.html

 修复sysfs的设备设置驱动信息

Log: 修复卸载驱动时问题

Bug: https://pms.uniontech.com/bug-view-262223.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • setInfoFrom_sysFS函数中,删除了原有的注释代码块,但没有提供新的实现或注释,可能会影响代码的可读性和后续的维护。
  • setInfoFromCatDevices函数中的return true;语句被添加到了函数定义之外,这可能是一个逻辑错误,通常在C++中,函数声明应该包含;来表示函数的结束。

是否建议立即修改:

@myk1343
Copy link
Contributor

myk1343 commented Jul 1, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jeffshuai, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeffshuai
Copy link
Author

/merge

@deepin-bot deepin-bot bot merged commit dd4f7d5 into linuxdeepin:master Jul 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants