Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UI] Adjustment of Top and Bottom Margins in Year Month View #246

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Aug 22, 2024

The first sub item has a top margin of 12.5px, the last sub item has a bottom margin of 12.5px, and the middle sub item has a spacing of 25px

Log: [UI] Adjustment of Top and Bottom Margins in Year Month View
Bug: https://pms.uniontech.com/bug-view-268925.html

  The first sub item has a top margin of 12.5px, the last sub item has a bottom margin of 12.5px, and the middle sub item has a spacing of 25px

Log: [UI] Adjustment of Top and Bottom Margins in Year Month View
Bug: https://pms.uniontech.com/bug-view-268925.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MonthCollection.qmlYearCollection.qml中,itemHeight属性从整数类型更改为浮点数类型,这可能会影响布局和缩放行为。需要确认这是否是预期的更改。
  • YearCollection.qml中,spacing属性从20更改为0,这可能会影响布局的紧凑性。需要确保这是否是预期的更改,以及是否有其他代码依赖于spacing属性。
  • MonthImageYearImage组件中,anchors.verticalCenter被添加到MouseArea,这可能是为了确保鼠标点击事件在图片的中心触发。需要验证这是否是必要的更改,以及是否有其他代码依赖于anchors.verticalCenter
  • YearCollection.qml中,source属性中的itemCount被添加到图片的URL中,这可能是为了更新图片缓存,确保图片在更改时能够被重新加载。需要验证这是否是必要的更改,以及是否有其他代码依赖于itemCount

是否建议立即修改:

  • 是,需要确保这些更改是经过充分考虑的,并且不会对现有功能产生负面影响。如果这些更改是必要的,应该立即进行修改。如果不是,应该撤销这些更改,以避免潜在的问题。

@myk1343
Copy link

myk1343 commented Aug 22, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link
Contributor

@wyu71 wyu71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: starhcq, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit 14dd1c2 into linuxdeepin:master Aug 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants