Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Config] The default width and height adjustment of the main window is 1150 * 800 #245

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Aug 21, 2024

1.The default width and height adjustment of the main window is 1150 * 800
2.Default width and height adaptation for different resolutions

Log: [Config] The default width and height adjustment of the main window is 1150 * 800
Bug: https://pms.uniontech.com/bug-view-268195.html

…dow is 1150 * 800

   1.The default width and height adjustment of the main window is 1150 * 800
   2.Default width and height adaptation for different resolutions

Log: [Config] The default width and height adjustment of the main window is 1150 * 800
Bug: https://pms.uniontech.com/bug-view-268195.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • getlastWidth函数中,将默认宽度乘以0.599而不是0.600000,这是一个非常小的改动,但可能影响窗口宽度的计算。
  • getlastHeight函数中,将默认高度乘以0.741而不是0.600000,这是一个非常小的改动,但可能影响窗口高度的计算。

是否建议立即修改:

  • 是,建议立即检查这些更改是否符合预期的窗口大小计算逻辑。如果这些更改是故意的,并且已经通过了所有相关的测试,那么可以接受这些更改。如果这些更改是无意的,那么应该立即修复以避免潜在的窗口大小问题。

@pengfeixx
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit 7122225 into linuxdeepin:master Aug 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants