Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create a temporary connection to an unconnected wireless network #293

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

caixr23
Copy link
Contributor

@caixr23 caixr23 commented Dec 27, 2024

  1. Create a temporary connection to an unconnected wireless network
  2. Modify the flight mode configuration to default display

pms: BUG-297861
pms: BUG-295501

1. Create a temporary connection to an unconnected wireless network
2. Modify the flight mode configuration to default display

pms: BUG-297861
pms: BUG-295501
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • config/org.deepin.dde.network.json 文件中,networkAirplaneModevaluefalse 改为 true,需要确认这一改动是否符合业务逻辑需求。
  • net-view/operation/private/netmanagerthreadprivate.cpp 文件中,新增了 ConfigSetting::instance()->networkAirplaneMode() 的检查,确保只有在 networkAirplaneModetrue 时才启用飞行模式。
  • net-view/operation/private/netmanagerthreadprivate.cpp 文件中,updateAirplaneModeEnabledable 函数的参数名 enabledable 应为 enabled,以保持一致性。
  • net-view/operation/private/netmanagerthreadprivate.cpp 文件中,addAndActivateConnection 函数被替换为 addAndActivateConnection2,需要确认新函数是否支持所有旧函数的功能,并确保 MANULCONNECTION 常量已定义。
  • src/configsetting.cpp 文件中,m_alwaysFromNM 的默认值从 false 改为 true,需要确认这一改动是否符合业务逻辑需求。

是否建议立即修改:

  • 确认 networkAirplaneModevalue 改动是否符合业务逻辑需求。
  • 修正 updateAirplaneModeEnabledable 函数的参数名 enabledableenabled
  • 确认 addAndActivateConnection2 函数的使用是否正确,并确保 MANULCONNECTION 常量已定义。
  • 确认 m_alwaysFromNM 的默认值改动是否符合业务逻辑需求,并确保这一改动不会影响其他功能。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 4fc5479 into linuxdeepin:master Dec 27, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants