Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [computer]Getting the UUID is stuck, causing the interface to freeze #2013

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

pengfeixx
Copy link
Contributor

Put the obtained UUID into the thread for execution

Log: Fixed some known issues
Bug: https://pms.uniontech.com/bug-view-254659.html

…eeze

Put the obtained UUID into the thread for execution

Log: Fixed some known issues
Bug: https://pms.uniontech.com/bug-view-254659.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • asyncQueryBlockInfoasyncQueryProtocolInfo函数中,使用QtConcurrent::run替代手动处理的线程。
  • asyncQueryInfo函数中使用了FinallyUtil来确保在函数执行完成后执行清理操作。
  • exit变量在ComputerView的构造函数中被设置为false,但在析构函数中没有被使用。
  • handleDisksVisiblehandleComputerItemVisible函数中添加了对dp->exit的检查,但是在ComputerView的析构函数中没有看到对exit变量的处理。

是否建议立即修改:

建议的修改:

  • ComputerView的析构函数中添加对exit变量的处理,确保在退出时能够正确地清理资源。
  • 检查exit变量在ComputerView的其他生命周期方法中的使用,确保它被正确地设置和处理。
  • 确保FinallyUtil的使用是线程安全的,特别是在多线程环境下。
  • 验证QtConcurrent::run的使用是否正确处理了线程安全问题,以及是否有必要使用FinallyUtil来确保清理操作的正确执行。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 474d5b4 into linuxdeepin:master Jun 11, 2024
17 checks passed
@pengfeixx pengfeixx deleted the bugfix branch June 11, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants