Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to delete files in vault #2007

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

liyigang1
Copy link
Contributor

Wrong parameter passed in

Log: Unable to delete files in vault
Bug: https://pms.uniontech.com/bug-view-257793.html

@liyigang1 liyigang1 force-pushed the fix-1 branch 3 times, most recently from a7802f4 to a0ec841 Compare June 3, 2024 09:03
liyigang1 added 2 commits June 3, 2024 17:24
Wrong parameter passed in

Log: Unable to delete files in vault
Bug: https://pms.uniontech.com/bug-view-257793.html
…n will skip the previous operation's revocation

No processing was done after cancellation

Log:  After selecting "Cancel" when revoking, attempting to do so again will skip the previous operation's revocation
Bug: https://pms.uniontech.com/bug-view-257853.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FileOperationsEventReceiver::newDocmentName函数中,参数suffix被错误地引用为suffixex,这是一个拼写错误。
  • FileOperationsEventReceiver类中的DoDeleteErrorType枚举应该定义为公共的,以便在测试文件中访问。
  • OperationsStackManagerDbus::SaveOperationsOperationsStackManagerDbus::CleanOperations函数中,对values的访问应该在if (op.contains("stackBack"))条件之外,以避免潜在的未定义行为。
  • OperationsStackManagerDbus::SaveOperationsOperationsStackManagerDbus::CleanOperations函数中,op变量应该在if (op.contains("stackBack"))条件之外初始化,以避免潜在的未定义行为。
  • OperationsStackManagerDbus::SaveOperationsOperationsStackManagerDbus::CleanOperations函数中,back变量的作用域应该更明确,以提高代码的可读性。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 2cdaf22 into linuxdeepin:master Jun 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants