Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report: The x230-maximized image is working now on x230t without the backspace keyboard error. But Power button misbehave and no sound card. Seperate board configs needed for x230t #1744

Open
fhvyhjriur opened this issue Aug 5, 2024 · 15 comments · May be fixed by #1791
Assignees

Comments

@fhvyhjriur
Copy link
Contributor

@tlaurion wrote many times and took this even in the year 2024 often as a example for how missing testing is blocking adding the support for a device. The example: x230t. This was famous for not having a working backspace key when a heads x230 image was installed on it. I can report from years ago, that this was the case. The keyboard was not working as expected but back then, i had not the chance to test further/again.
Now i have again access to a x230t and the first thing i did was to install https://output.circle-artifacts.com/output/job/ddd46474-d44a-47ed-8035-d22d97171c0d/artifacts/0/build/x86/x230-maximized/heads-x230-maximized-v0.2.0-2254-g27d09d4.rom
I was expecting it to have the same keyboard issue like years ago, but keyboard worked perfectly fine. Of course at the moment you have to force flash with flashrom because flashrom correctly reports, that the coreboot model number inside the file is not x230t but its x230 (there was a x230t coreboot image on it).

Is your feature request related to a problem? Please describe.

There was a problem that seem to be gone on the latest releases.

Describe the solution you'd like

Add x230t with default coreboot x230t config and x230t name to heads to finish up the work that started years ago for this model.

Describe alternatives you've considered
None?

@tlaurion
Copy link
Collaborator

tlaurion commented Aug 5, 2024

@fhvyhjriur stays over reboot? Problem was that it was not staying (cold boot/war boot/reboot), same reported on some x230 since then as well.

Coreboot devels contacted, even issues opened upstream... Still considered not working and would require ps2 code modified under coreboot to force proper keyboard (AT2 translated), bypassing automatic flawed detection, or having linux kernel module switch to be forced for all x230. Behavior being fixated by first ps2 keyboard initializer.

Both solutions not yet implemented. Basically you are lucky here and real cause of issue still not fixed in code AFAIK.

@tlaurion
Copy link
Collaborator

tlaurion commented Aug 5, 2024

For some traceability.

2254 is 27d09d4 so 24.04.02 coreboot based with ps2 init still on.

If someone can invest time to see if ps2 code was rewritten or replicate this RAW/TRANSLATED AT2 keyboard detection and can confirm that the problem vanished once and for all and pinpoint why and where this was fixed, then @fhvyhjriur x230 and x230t should be exactly the same board from coreboot perspective last time I checked. There would not be any need of creating/maintaining yet another board variant, and past e-ink across everything searchable x230t should answer your questions in this repo.

@tlaurion tlaurion self-assigned this Aug 5, 2024
@tlaurion
Copy link
Collaborator

tlaurion commented Aug 5, 2024

Assigned to myself because /i have a x230t somewhere, so if I can have behavior stable across reboots/cold boot/reboots, then x230 could be advertised as also working on x230t and this issue could be closed as resolved when actual code fix si traced back to why the problem is fixed now. Maybe TOP_DOWN allocator?! unsure really, this being fixed without reason is just weird as of now.

@tlaurion
Copy link
Collaborator

tlaurion commented Aug 16, 2024

Backspace works on cold boot after first flash. Testing #1541 derivate on undusted x230t real hardware.

Will reply here after reboot/warm boot/reset->q4.2 after total re-ownership (btrfs partitions reencryption from custom 4.2 install on disk for #1541 with proper Argon2 sturdier key addition from TPM DUK and proper reencryption speeds and reusing OS install LUKS containers)

@tlaurion
Copy link
Collaborator

Weird, I confirm this works on x230t now.

Time to understand why now. Anybody sees what changed under coreboot?

@tlaurion
Copy link
Collaborator

tlaurion commented Aug 16, 2024

Hmmm will need to do this local, cannot just do files changes from web GUIs to sshare process with community, too many changes.

coreboot/coreboot@4.22_branch...24.02_branch

@tlaurion
Copy link
Collaborator

Nothing directly linked to PC80 not PS/2 from what I see....

@tlaurion
Copy link
Collaborator

tlaurion commented Aug 16, 2024

Well, could be linux kernel version bump as well, good news is that its fixed :/

Note that I only tested coreboot 24.02.01 with linux 5.10.214 per https://github.com/linuxboot/heads/pull/1541/files#diff-2b51dc9d1602ab31c054d57804a441059a68dcfdf7f3c407f83a85148bcecfc6R31

@fhvyhjriur: what would fix this issue? As of today, x230t was considered not supported by Heads x230 board flavors. Today it would. A note added under board configs?

# Configuration for a X230 running Qubes 4.1 and other Linux Based OSes (through kexec)

@tlaurion
Copy link
Collaborator

@fhvyhjriur ping

@tlaurion
Copy link
Collaborator

tlaurion commented Sep 6, 2024

@fhvyhjriur reping

@fhvyhjriur
Copy link
Contributor Author

Some GPIO's was strange(my expectation) on my test but the keyboard was now fine.

Could you confirm following issues on your hardware?

  • The Powerbutton for example does not work as a powerbutton any more. Even the default ATX-Shutdown that have to always work does not work. You can turn the x230t on with the powerbutton, but then even pressing and holding it for a long time does not turn the x230t off.
  • Soudcard is not working

Because this is been asked often on coreboot development: Yes, S3 is working fine

@tlaurion
Copy link
Collaborator

Some GPIO's was strange(my expectation) on my test but the keyboard was now fine.

Could you confirm following issues on your hardware?

  • The Powerbutton for example does not work as a powerbutton any more. Even the default ATX-Shutdown that have to always work does not work. You can turn the x230t on with the powerbutton, but then even pressing and holding it for a long time does not turn the x230t off.
  • Soudcard is not working

Because this is been asked often on coreboot development: Yes, S3 is working fine

That answers the question then. No I haven't tested extensively x230t but keyboard. This means x230t cannot be supported through x230 board flavor and x230t coreboot config should be brought in: hotp and non-hotp variants just like the x230.

PR welcome, @fhvyhjriur. Use helpers of modules/coreboot end file to modify and save config after haviong copied boar configs, renamed x230t coreboot config to a distinct file and make something that works for you. If you create a PR. I will test and merge.

@tlaurion tlaurion changed the title Report: The x230-maximized image is working now on x230t without the backspace keyboard error Report: The x230-maximized image is working now on x230t without the backspace keyboard error. But Power button misbehave and no sound card Sep 10, 2024
@tlaurion
Copy link
Collaborator

Renamed issue

@tlaurion tlaurion changed the title Report: The x230-maximized image is working now on x230t without the backspace keyboard error. But Power button misbehave and no sound card Report: The x230-maximized image is working now on x230t without the backspace keyboard error. But Power button misbehave and no sound card. Seperate board configs needed Sep 10, 2024
@tlaurion tlaurion changed the title Report: The x230-maximized image is working now on x230t without the backspace keyboard error. But Power button misbehave and no sound card. Seperate board configs needed Report: The x230-maximized image is working now on x230t without the backspace keyboard error. But Power button misbehave and no sound card. Seperate board configs needed for x230t Sep 10, 2024
@fhvyhjriur

This comment was marked as off-topic.

@tlaurion
Copy link
Collaborator

tlaurion commented Sep 11, 2024

Some GPIO's was strange(my expectation) on my test but the keyboard was now fine.
Could you confirm following issues on your hardware?

  • The Powerbutton for example does not work as a powerbutton any more. Even the default ATX-Shutdown that have to always work does not work. You can turn the x230t on with the powerbutton, but then even pressing and holding it for a long time does not turn the x230t off.
  • Soudcard is not working

Because this is been asked often on coreboot development: Yes, S3 is working fine

That answers the question then. No I haven't tested extensively x230t but keyboard. This means x230t cannot be supported through x230 board flavor and x230t coreboot config should be brought in: hotp and non-hotp variants just like the x230.

PR welcome, @fhvyhjriur. Use helpers of modules/coreboot end file to modify and save config after haviong copied boar configs, renamed x230t coreboot config to a distinct file and make something that works for you. If you create a PR. I will test and merge.

@fhvyhjriur I created x230t PR at #1791. Just like I did x200 which lead nowhere. I'm doing my best but this is unfortunately of low interest for me and the community, i'm sorry: this is reality.

Trail of commands there showing you not needing to be a developer, just somewhat really interested into making this go forward for yourself if you really wanted: learning is possible for all curious enough. Asking others to do that for oneself for whatever personal interests not matched by community won't be sustainable, that is a fact. Selfish contributionnism is a thing as already discussed elsewhere. This is my last attempt to fulfill user needs that don't match my priorities or bugfixes for what already works and have Pareto outcome. Consider this said multiple times. If #1791 doesn't work, then this is upstream issue. No I won't create x220t board flavors nor add other boards not brought back by users interested enough into participating to this project and making things work for others. Once again Heads is a community FOSS project, and contributionnism is expected in form of code/donations/testing: testing doesn't just mean saying works/ot works, it means making it work or being able to troubleshoot leading for things to work for othrs. Otherwise this is me giving infinite supplies of fish where what I try to do is give fishing lines. Last unsustainable attempt of pleasing testers that will only say: works/doesn't work. Boards should be brought to master by people technical enough to learn how things work and move the ecosystem forward. Sorry, but time and resources are limited.

I'm grateful for your testing and support to Heads, but again, I wish you were bringing people who can help fix things that doesn't work, not just say things doesn't work. Boards expected to work having a "works" tag is good, but as also previously said: when things won't work, what am I supposed to do next? How much time you expect me to put in things/boards nobody else uses? I get you want blobless hardware, this is my fight too. But gains are limited unless technical enough to make things work for others, not just say it doesn't work. Know others that have that board from coreboot? Bring those people in. Open issues at coreboot. Don't expect me to fix everything for everyone on boards not yet supported under Heads. Hope you understand this. I cannot explain priorities in each issues/PR. Technical people should port boards they care about to Heads and collaborate upstream for things that don't work. Heads is a coreboot user, and therefore, things not working under coreboot needs to be worked upstream, where downstream (Heads) can at best be used to build and stitch roms to be tested upstream for specific configurations: that requires upstream participation. If you think you are not technical enough to take that task, there is not much I can do here to support your adventure. You need to connect to more technical board owners of yours that can help work problems out into solutions; don't expect me to be that person for all boards you are interested in. I unfortunately do not/will not have the time to support your interests alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants