Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x230-maximized-fhd_edp variations from untested edf200e7913c62975a424cfb9dbd579747d0665c works fine #1444

Closed
tlaurion opened this issue Jul 19, 2023 · 4 comments · Fixed by #1448

Comments

@tlaurion
Copy link
Collaborator

tlaurion commented Jul 19, 2023

@tlaurion You can remove x230-maximized-fhd_edp variations from untested, edf200e works fine on my eDP-modded X230.
Sorry for not being able to test it sooner.

Originally posted by @pcm720 in #1421 (comment)

@tlaurion
Copy link
Collaborator Author

tlaurion commented Jul 19, 2023

with eDP 4.0 board and 1440p display.

Originally posted by @pcm720 in #1387 (comment)

@tlaurion
Copy link
Collaborator Author

tlaurion commented Jul 19, 2023

Also note that some participation under https://review.coreboot.org/c/coreboot/+/28950. Better from board owners then from me (where past comments have not led to a merge upstream, meaning I would have to maintain this, which I have no intention of doing so).

Originally posted by @tlaurion in #1387 (comment)


@n4ru @computer-user123 @Tonux599 @househead @pcm720: Your input is needed under https://review.coreboot.org/c/coreboot/+/28950 so that edp patch is not maintained downstream under Heads, but merged upstream under coreboot

As of today:

x230-fhd/edp variant: @n4ru @computer-user123 (nitro caster board) @Tonux599 @househead @pcm720 (eDP 4.0 board and 1440p display)

@pcm720
Copy link

pcm720 commented Jul 19, 2023

I don't mind doing that, I just wish I knew the kind of input they need to merge this patch.
AFAIK, all kits currently sold on AliExpress are using USB HID device to control brightness from OS, only Nitrocaster's kit taps into original LVDS connector for brightness control. Other than that, all eDP kits should be essentially the same, so this patch should work for any kit that's tapping into DisplayPort output from the docking connector.
I'm using eDP V4.0 kit from AliExpress.

@tlaurion
Copy link
Collaborator Author

tlaurion commented Aug 2, 2023

Should close when #1448 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants