-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement genhtml : Increase contrast of text (a11y) #214
Comments
I think you can override the default CSS to modify the colors if you like - though it may be that there are some hard-coded attributes that need to be fixed. I'm not a GUI person - so have no feel for what a good color scheme would be. Happy to listen to suggestions, though. If you thought you would like to try, then directions are in the README. Easiest is to just clone the repo, cd to the top-level directory of your clone, and type "make test". |
Hello, thanks for the quick response! I'll document what are some of the css class that need better contrast, and I'll try to make a pull request with some more readable color. Keep in mind that I opened an issue instead of a pull request, because my UI design skill are also quite lackluster. The best I can do is a color wheel and changing until the contrast is better 😅 |
If we are making changes, it would be good idea to pass suggestions by someone with red/green and blue/yellow color blindness. If you or somebody else was interested enough to suggest a full palette for those individuals, it would be pretty easy to add an option to the tool so that the user could select the one that works best for them (assuming they didn't want to override the CSS). |
Hello. Regarding color blindness, a possible solution would be the introduction of an I will work on contrast for the existing style during this weekend. |
greyscale is a good idea. Had not thought of that. |
There is also the simulator https://www.color-blindness.com/coblis-color-blindness-simulator/ Not sure how realistic it is. Nonetheless, the grayscale view has most problems, and is indeed unreadable because of low contrast. |
Report produced by genhtml can have a low contrast. This is mainly noticeable when using the
--dark-mode
option, wheretableHead
text is black on grayish blue, which gives a poor WCAG contrast of 2,46 . This makes text hard to read, especially if one has vision problem.This issue does not only affect the dark-mode table header, as another notable contrast issue is the light-mode visited link, with a contrast ratio of 1,75 . There are probably more place that I missed where the contrast is subpar, or could be improved for better readability.
Here is a quick demo of a possible improvement.
Light-mode
Dark-mode
I do not know Perl, nor do I know how to build the project, so I cannot create a pull request to implement this change.
The text was updated successfully, but these errors were encountered: