Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint data structure for nvme API #448

Open
igaw opened this issue Jul 26, 2022 · 3 comments
Open

Add endpoint data structure for nvme API #448

igaw opened this issue Jul 26, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@igaw
Copy link
Collaborator

igaw commented Jul 26, 2022

The MI API uses the endpoint data struct to abstracts from implementation details. Introduce an similiar API for the nvme interface. The goal here is to decouple from the low level API and be able to mock certain APIs for testing.

@igaw igaw added this to the 2.0 milestone Jul 26, 2022
@igaw igaw added the enhancement New feature or request label Jul 26, 2022
@jk-ozlabs
Copy link
Collaborator

It would be great if we can use a common struct between the direct and MI interfaces - this means we could avoid duplicating the API for each transport.

I'm happy to propose something for this, if you like.

@igaw
Copy link
Collaborator Author

igaw commented Aug 16, 2022

Sorry, for the late response. Public holiday :)

Let me have a look at it now. IIRC this work was depending on other work? Anyway, I'l review it now (coffee needed)

Yes, please. If you have something in mind I am glad to discuss it :)

BTW, I've planned this for v2.0 because I expected it to break the current API, but I might be wrong.

@jk-ozlabs
Copy link
Collaborator

Yes, this would be a fairly big change - it would alter the arguments for almost every function. Definitely something for a ABI-breaking milestone.

I'll put together some sketches for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants