Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set log level before klog.SetLogger #12914

Closed
wants to merge 1 commit into from
Closed

fix: set log level before klog.SetLogger #12914

wants to merge 1 commit into from

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Jul 30, 2024

Fixes #12887

@mikutas mikutas marked this pull request as ready for review July 30, 2024 10:15
@mikutas mikutas requested a review from a team as a code owner July 30, 2024 10:15
@mikutas mikutas changed the title fix(cli): set log level of logrus fix: set log level of logrus Jul 30, 2024
adleong
adleong reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikutas! Can you share how you tested this? Do you have some examples of what the log output looks like before vs after this change?

@mikutas mikutas marked this pull request as draft July 31, 2024 00:38
@mikutas mikutas changed the title fix: set log level of logrus fix: set log level before klog.SetLogger Jul 31, 2024
@mikutas mikutas force-pushed the 12887 branch 3 times, most recently from a9d5990 to a61b2ae Compare July 31, 2024 04:44
@mikutas mikutas closed this Aug 12, 2024
@mikutas mikutas deleted the 12887 branch August 12, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adleong adleong adleong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting -log-level debug introduces client-go logging at the INFO level
2 participants
@mikutas @adleong