Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support kafka executables without shell extension? #50

Open
simplesteph opened this issue Dec 14, 2016 · 2 comments · May be fixed by #51
Open

Support kafka executables without shell extension? #50

simplesteph opened this issue Dec 14, 2016 · 2 comments · May be fixed by #51
Labels
enhancement

Comments

@simplesteph
Copy link

Hi,

Is it possible to have the kafka-tools support kafka-reassign-partitions instead of kafka-reassign-partitions.sh ? For example, the confluent Kafka images do an apt-get install which go and places the shell scripts directly in the /usr/bin folder, but they don't have the .sh extension.

It'd be great if kafka-tools could support either.

Thoughts on this? I can try to do a PR but it might be messy

Regards,
Stephane
@simplesteph simplesteph linked a pull request Dec 14, 2016 that will close this issue
Open
@bringhurst
Copy link
Member

Seems like a good idea. Perhaps we should have an env var for KAFKA_DIST_BIN that points to the prefix for the local installation of Kafka. If that variable isn't set, then it just tries a few common locations before giving up.

@simplesteph
Copy link
Author

@bringhurst have you seen #51 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added option to look for non .sh executables simplesteph/kafka-tools
2 participants
@bringhurst @simplesteph