Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really need manual sequence creation? #206

Open
Konard opened this issue Sep 1, 2024 · 0 comments
Open

Do we really need manual sequence creation? #206

Konard opened this issue Sep 1, 2024 · 0 comments

Comments

@Konard
Copy link
Member

Konard commented Sep 1, 2024

https://github.com/deepcase/deeplinks/blob/94d5926fdfaa0003c4a9c28980840d66512fdc4f/migrations/1616701513782-links.ts#L19-L23

Maybe we can just use the sorter version that makes the same thing using id BIGSERIAL PRIMARY KEY?
Or maybe it does not do the same thing?

CREATE TABLE ${SCHEMA}."${TABLE_NAME}" (id BIGSERIAL PRIMARY KEY, from_id bigint DEFAULT 0, to_id bigint DEFAULT 0, type_id bigint NOT NULL);

I just tested this SQL statement:

CREATE TABLE test_table (
    id BIGSERIAL PRIMARY KEY
);

And got this result:
Screenshot_20210916_215335

As far as I can find in https://www.postgresql.org/docs/current/sql-createsequence.html

CREATE SEQUENCE ${TABLE_NAME}_id_seq 
AS bigint 
START WITH 1 
INCREMENT BY 1 
NO MINVALUE
NO MAXVALUE
CACHE 1;

all these settings are default, so this is an equivalent of:

CREATE SEQUENCE ${TABLE_NAME}_id_seq;

And all the above is exact equivalent of just id BIGSERIAL PRIMARY KEY.


Forked from deep-foundation/deeplinks#14 by https://github.com/konard/gh-org-migrator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant