Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with arge number of files + nested file structure in vendor/bower #5

Open
un33k opened this issue Apr 27, 2014 · 3 comments
Open

Comments

@un33k
Copy link

un33k commented Apr 27, 2014

With the introduction of the vendor/bower directory, we need to add "vendor/bower" to the watch ignore option.

Ref: testem/testem#301

Details:
I have tested this where I have lot of directories in the vendor/bower directory and if I run "lineman spec", then it fails with error watch: EMFILE. (see Ref)

It seems that testem + fireworm have addressed this issue and bumped the version up.

Solution:

  1. Add skipDirEntryPatterns:['node-modules', 'vendor/bower', '.*'] to fireworm config via this module
  2. Update testem+fireworm in lineman itself.
  3. Update the README to suggest the bower directory be created under the node_modules

Since this module creates 'vendor/bower', it would be nice that it would also handle the testem+firewom config directly.

@un33k
Copy link
Author

un33k commented Apr 30, 2014

Pushed a patch to fireworm that also ignores the bower_components directory. This is the default directory created by bower if .bowerrc is not setting a different directory.

airportyh/fireworm#5

Any particular reason for /vendor/bower recommendation in the instruction?

@davidmyersdev
Copy link

@un33k, I am also curious about this choice. I opted for the default directory of /bower_components in my installation. Of course, you will have to commit your .bowerrc file if you don't want that to mess up during initial installation.

@jayharris
Copy link
Member

The intent was purely to keep all Vendor files together. By using the vendor directory in .bowerrc, everything is in one spot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants