From 5bab9c70cf7b360a6200fc059e95981234ec1080 Mon Sep 17 00:00:00 2001 From: jaredoconnell Date: Wed, 11 Sep 2024 10:45:39 -0400 Subject: [PATCH] Address review comments --- masonry/examples/grid_masonry.rs | 3 +-- masonry/src/widget/grid.rs | 7 +++++++ ...masonry__widget__grid__tests__with_negative_spacing.png | 3 +++ 3 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 masonry/src/widget/screenshots/masonry__widget__grid__tests__with_negative_spacing.png diff --git a/masonry/examples/grid_masonry.rs b/masonry/examples/grid_masonry.rs index 29fd8df54..77317238e 100644 --- a/masonry/examples/grid_masonry.rs +++ b/masonry/examples/grid_masonry.rs @@ -45,8 +45,7 @@ fn grid_button(params: GridParams) -> Button { pub fn main() { let label = SizedBox::new( Prose::new( - "Change spacing by right and \ - left clicking on the buttons", + "Change spacing by right and left clicking on the buttons", ) .with_text_size(14.0) .with_text_alignment(Alignment::Middle), diff --git a/masonry/src/widget/grid.rs b/masonry/src/widget/grid.rs index e81e919d3..ec0cec36a 100644 --- a/masonry/src/widget/grid.rs +++ b/masonry/src/widget/grid.rs @@ -354,6 +354,13 @@ mod tests { grid.set_spacing(7.0); }); assert_render_snapshot!(harness, "with_changed_spacing"); + + // Make the spacing negative + harness.edit_root_widget(|mut grid| { + let mut grid = grid.downcast::(); + grid.set_spacing(-4.0); + }); + assert_render_snapshot!(harness, "with_negative_spacing"); } #[test] diff --git a/masonry/src/widget/screenshots/masonry__widget__grid__tests__with_negative_spacing.png b/masonry/src/widget/screenshots/masonry__widget__grid__tests__with_negative_spacing.png new file mode 100644 index 000000000..c8dd392d8 --- /dev/null +++ b/masonry/src/widget/screenshots/masonry__widget__grid__tests__with_negative_spacing.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:1d1c79d02e5f0b22b6326e7926c0af2880cdb9c4e852b04fde63cab9cce10da5 +size 6897