Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to sign APEX files during the build? #646

Open
petefoth opened this issue Jun 26, 2024 · 0 comments
Open

Do we need to sign APEX files during the build? #646

petefoth opened this issue Jun 26, 2024 · 0 comments

Comments

@petefoth
Copy link
Contributor

petefoth commented Jun 26, 2024

We don't currently sign APEX files during the build. I don't know

  1. What the implications are of not signing them
  2. Whether we need to add code to
    a. generate the apk-specific keys
    b. sign the APEXes during the build

Background

  • APEX files are used in OTA updates 1
  • LOS Wiki describes how to
    • generate APEX keys 2
    • using the keys when generating and signing target files 3. Some of the apks are signed using the release key, some use the newly generated apk-specific keys
  • The /e/OS Docker image
    • does not generate apk-specific keys when generating signing keys 4
    • signs each apk with the apk-specific key if the key files exist 5 before calling ota_from_target_files

Footnotes

  1. https://source.android.com/docs/core/ota/apex

  2. https://wiki.lineageos.org/signing_builds#generate-keys-without-a-password

  3. https://wiki.lineageos.org/signing_builds#generating-and-signing-target-files

  4. https://gitlab.e.foundation/e/os/docker-lineage-cicd/-/blob/master/src/init.sh?ref_type=heads#L35

  5. https://gitlab.e.foundation/e/os/docker-lineage-cicd/-/blob/master/src/build.sh?ref_type=heads#L382

@petefoth petefoth changed the title We need to do more when signing builds Do we need to sign APEX files Jun 27, 2024
@petefoth petefoth changed the title Do we need to sign APEX files Do we need to sign APEX files during the build? Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant