Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urljoin can't return the proper full url #225

Open
sundy-li opened this issue Dec 19, 2019 · 0 comments
Open

urljoin can't return the proper full url #225

sundy-li opened this issue Dec 19, 2019 · 0 comments
Assignees
@kfdm

Comments

@sundy-li
Copy link

sundy-li commented Dec 19, 2019 •
edited
Loading

I saw lots of code using urljoin, if we let the second argument starts with '/', urljoin will simply take the second argument as the path of the URL.

TestsCode

>>> urljoin("http://abc:9090/prometheus/",  "/aa/bb" )
'http://abc:9090/aa/bb'
>>> urljoin("http://abc:9090/prometheus",  "/aa/bb" )
'http://abc:9090/aa/bb'
@kfdm kfdm self-assigned this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfdm kfdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfdm @sundy-li