Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add --comment to multi-gitter close #440

Open
jtgrohn opened this issue Dec 7, 2023 · 2 comments
Open

Feature request: Add --comment to multi-gitter close #440

jtgrohn opened this issue Dec 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jtgrohn
Copy link

jtgrohn commented Dec 7, 2023

The feature request
Add --comment to multi-gitter close so that it can close a PR with a comment indicating why it was closed

My use case
I want to supersede Pull Requests with new ones with different branch names. I want to be able to close the old PRs with a comment saying something along the lines of

Superseded by branch <branch_name>
@jtgrohn jtgrohn added the enhancement New feature or request label Dec 7, 2023
@lindell
Copy link
Owner

lindell commented Dec 8, 2023

I think this would be covered by the review command PR.

#332

@jtgrohn
Copy link
Author

jtgrohn commented Dec 11, 2023

So the idea there would be to review then close?

The result would be similar I think, but it would be nicer to have the comment and pull request close timestamps be closer together. If I'm running multi-gitter on hundreds of repos, there would be a not insignificant delay between commenting and closing.

I'm looking to do the equivalent of
image

not comment and then click close
image

(note the Close button text change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants