New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move redshift to Physical Model #76

Closed

OliviaLynn opened this issue Aug 23, 2024 · 0 comments · Fixed by #122

Assignees

Member

OliviaLynn commented Aug 23, 2024

Instead of applying redshift as an effect, I think we should make it part of PhysicalModel. If redshift != 0, PhysicalModel.evaluate always calls the pre-effect function to transform the frame and then always calls the post effect afterward. This way the user does not need to manually add redshift effects.

OliviaLynn self-assigned this

OliviaLynn mentioned this issue

Passband/PassbandGroup new interface #111

Merged

OliviaLynn mentioned this issue

Move redshift from effect to physical model #122

Merged

OliviaLynn closed this as completed in #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment