Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passband general improvements #113

Open
3 tasks
OliviaLynn opened this issue Sep 18, 2024 · 0 comments
Open
3 tasks

Passband general improvements #113

OliviaLynn opened this issue Sep 18, 2024 · 0 comments

Comments

@OliviaLynn
Copy link
Member

  • We now have LSST transmission tables stored in our test data directory (and a passband_dir fixture defined in our conftest); it would be nice to rewrite some of our unit tests to use these tables rather than toy data

  • Use astropy units in Passband code

Should we just use astropy units here so we can use all their conversions?

Originally posted by @jeremykubica in #111 (comment)

  • Refactor Passband constructor

I think it is fine to keep this as-is, but an alternative approach that might be more modular approach might be to have the constructor take a table and then to add two class methods:

@classmethod
def from_file(cls, table_path: str, ...):
   load the file
   ...
   return Passband(table, ...)

@classmethod
def from_url(cls, table_url: str, force_download: bool, ...):
    do the download
    ...
    return Passband(table, ...)

Originally posted by @jeremykubica in #111 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant