Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index.html lacks proper </body> and </html> tag in version 2.2.0 #1

Open
birdli66 opened this issue Oct 15, 2018 · 2 comments
Open

index.html lacks proper </body> and </html> tag in version 2.2.0 #1

birdli66 opened this issue Oct 15, 2018 · 2 comments
Labels
bug

Comments

@birdli66
Copy link

No functional problem but the linshare-ui-user SPA lacks a proper HTML page structure in index.html.
The closing and end tags are cut off during build step.

Consequences: Depend on the browser (msot will auto-close).
As we do some minor WAF content rewriting on the top page, we ran into not being able to detect the page end.
@birdli66 birdli66 changed the title index.html lacks proper </body> and </html> tah in version 2.2.0 index.html lacks proper </body> and </html> tag in version 2.2.0 Oct 15, 2018
fmartin-linagora pushed a commit that referenced this issue Oct 19, 2018
Fixes #83, #1 - Add Vietnamese support
f14a455 
 - Update vi-VN contents
 - Remove legacy promise management, not useful anymore
 - Remove ng-if to remove VI lang from UI
@Klemele
Copy link
Contributor

Klemele commented Feb 1, 2019

Hey @birdli66 , thanks for the feedback.

I confirm the bug and I just added an issue in our internal CI.
I cannot tell you an exact date of fix for this as we have some hot topics on our plate but this will most likely be fixed in the next minor release.

Issue ref: 383

@Klemele Klemele added the bug label Feb 1, 2019
@birdli66
Copy link
Author

birdli66 commented Feb 1, 2019

many thx, no blocker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Klemele @birdli66