From d416f57b50436e4c2f4394ff13dca17f872eb93a Mon Sep 17 00:00:00 2001 From: Yadd Date: Sat, 23 Mar 2024 09:36:49 +0400 Subject: [PATCH] Drop some useless TODO --- packages/matrix-identity-server/src/account/register.ts | 2 -- packages/matrix-identity-server/src/matrixDb/index.ts | 1 - packages/matrix-identity-server/src/userdb/index.ts | 1 - packages/matrix-identity-server/src/utils.ts | 1 - packages/matrix-identity-server/src/utils/mailer.ts | 1 - .../matrix-identity-server/src/validate/email/requestToken.ts | 1 - 6 files changed, 7 deletions(-) diff --git a/packages/matrix-identity-server/src/account/register.ts b/packages/matrix-identity-server/src/account/register.ts index 3b513afd..b96a3b92 100644 --- a/packages/matrix-identity-server/src/account/register.ts +++ b/packages/matrix-identity-server/src/account/register.ts @@ -62,8 +62,6 @@ const Register = ( }) .catch((e) => { logger.warn(`Unable to validate token ${JSON.stringify(obj)}`, e) - - /* TODO: Matrix spec doesn't describe response to use it, check later if fixed */ send(res, 401, errMsg('sessionNotValidated', e)) }) }) diff --git a/packages/matrix-identity-server/src/matrixDb/index.ts b/packages/matrix-identity-server/src/matrixDb/index.ts index 4b6ba301..dc8d4766 100644 --- a/packages/matrix-identity-server/src/matrixDb/index.ts +++ b/packages/matrix-identity-server/src/matrixDb/index.ts @@ -59,7 +59,6 @@ class MatrixDB implements MatrixDBBackend { this.ready = new Promise((resolve, reject) => { this.db.ready .then(() => { - // TODO: insert here init if needed resolve() }) /* istanbul ignore next */ diff --git a/packages/matrix-identity-server/src/userdb/index.ts b/packages/matrix-identity-server/src/userdb/index.ts index 95b855c7..5c8351e9 100644 --- a/packages/matrix-identity-server/src/userdb/index.ts +++ b/packages/matrix-identity-server/src/userdb/index.ts @@ -83,7 +83,6 @@ class UserDB implements UserDBBackend { this.ready = new Promise((resolve, reject) => { this.db.ready .then(() => { - // TODO: insert here init if needed resolve() }) /* istanbul ignore next */ diff --git a/packages/matrix-identity-server/src/utils.ts b/packages/matrix-identity-server/src/utils.ts index cb033f37..2772c6fd 100644 --- a/packages/matrix-identity-server/src/utils.ts +++ b/packages/matrix-identity-server/src/utils.ts @@ -167,7 +167,6 @@ export const validateParameters: validateParametersType = ( } }) if (additionalParameters.length > 0) { - // TODO: for now, accept additional params logger.warn('Additional parameters', additionalParameters) } callback(content) diff --git a/packages/matrix-identity-server/src/utils/mailer.ts b/packages/matrix-identity-server/src/utils/mailer.ts index b617c88f..e504b862 100644 --- a/packages/matrix-identity-server/src/utils/mailer.ts +++ b/packages/matrix-identity-server/src/utils/mailer.ts @@ -21,7 +21,6 @@ class Mailer { host: conf.smtp_server, /* istanbul ignore next */ port: conf.smtp_port != null ? conf.smtp_port : 25, - // TODO: push this to options tls: { rejectUnauthorized: conf.smtp_verify_certificate } } if (conf.smtp_tls != null) { diff --git a/packages/matrix-identity-server/src/validate/email/requestToken.ts b/packages/matrix-identity-server/src/validate/email/requestToken.ts index d0673d69..294d0459 100644 --- a/packages/matrix-identity-server/src/validate/email/requestToken.ts +++ b/packages/matrix-identity-server/src/validate/email/requestToken.ts @@ -110,7 +110,6 @@ const RequestToken = (idServer: MatrixIdentityServer): expressAppHandler => { // TODO: check for send_attempt - // TODO generate sid and token and store them const sid = randomString(64) idServer.db .createOneTimeToken(