Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child theme - Remove theme attribute from Parent wp:template-part tags #54

Closed
Justinabes007 opened this issue Nov 10, 2023 · 0 comments · Fixed by #63
Closed

Child theme - Remove theme attribute from Parent wp:template-part tags #54

Justinabes007 opened this issue Nov 10, 2023 · 0 comments · Fixed by #63
Assignees
@krugazul @Justinabes007
Labels
[Status] Needs Dev Anything that needs development.
Milestone
1.2.0

Comments

@Justinabes007
Copy link
Contributor

Child theme missing Template parts - Header & Footer
Template part has been deleted or is unavailable error when enabling another theme.

This PR fixes an issue where the homepage returned the Template part has been deleted or is unavailable error when enabling another theme.

This issue was caused by the theme attribute being included in the wp:template-part tags for the header and footer of the home template.

A similar issue was detailed in WordPress/create-block-theme#242, which is where I identified the fix.
@Justinabes007 Justinabes007 added the [Status] Needs Dev Anything that needs development. label Nov 10, 2023
@Justinabes007 Justinabes007 self-assigned this Nov 10, 2023
@ashleyshaw ashleyshaw moved this to In Progress in LSX Nov 14, 2023
@krugazul krugazul added this to the 1.2.0 milestone Nov 14, 2023
krugazul added a commit that referenced this issue Nov 14, 2023
@krugazul
Find and replace of the theme attribute #54
71cc54c
@krugazul krugazul linked a pull request Nov 14, 2023 that will close this issue
Remove of the "theme" attribute #63
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in LSX Nov 14, 2023
@krugazul krugazul mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krugazul krugazul

@Justinabes007 Justinabes007

Labels
[Status] Needs Dev Anything that needs development.
Projects
No open projects
LSX
Archived in project
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Remove of the "theme" attribute lightspeedwp/lsx-design
2 participants
@krugazul @Justinabes007