Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Shutdown signal has no effect when chain syncing issues occur #9109

Open
ViktorTigerstrom opened this issue Sep 16, 2024 · 0 comments
Labels
bug Unintended code behaviour init Issues related to LND startup shutdown Issues related to shutdown process of LND

Comments

@ViktorTigerstrom
Copy link
Collaborator

ViktorTigerstrom commented Sep 16, 2024

When the chain syncing issue described in #9108 occurs, lnd will not shut down gracefully until the syncing process begins progressing again, even if a shutdown signal has been triggered.

The root cause is that this line in lnd.go is blocking:

lnd/lnd.go

Line 674 in edd9ade

synced, ts, err := activeChainControl.Wallet.IsSynced()

As a result, lnd will not shut down until this line has completed execution.

Regardless of what is causing the chain syncing issues, lnd should always be able to shut down. Therefore, we should modify the code so that this line is non-blocking, allowing lnd to proceed with the shutdown when a shutdown signal is triggered.

@ViktorTigerstrom ViktorTigerstrom added bug Unintended code behaviour needs triage init Issues related to LND startup shutdown Issues related to shutdown process of LND and removed needs triage labels Sep 16, 2024
@ViktorTigerstrom ViktorTigerstrom changed the title [bug]: Shutdown signal has no effect in case when chain syncing issues occur [bug]: Shutdown signal has no effect when chain syncing issues occur Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended code behaviour init Issues related to LND startup shutdown Issues related to shutdown process of LND
Projects
None yet
Development

No branches or pull requests

1 participant