Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run only custom_channels LiT itests #1129

Merged
merged 1 commit into from
Sep 19, 2024
Merged

ci: run only custom_channels LiT itests #1129

merged 1 commit into from
Sep 19, 2024

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Sep 19, 2024

Some lightning-terminal (LiT) itests are currently flaky. This commit restricts CI to running only the custom_channels subset of LiT itests.

Some lightning-terminal (LiT) itests are currently flaky. This commit
restricts CI to running only the `custom_channels` subset of LiT itests.
@ffranr ffranr self-assigned this Sep 19, 2024
@ffranr
Copy link
Contributor Author

ffranr commented Sep 19, 2024

I haven't tested this locally. I'm waiting on CI to see if things run as expected.

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM 🎉

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10940243772

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.005%) to 40.42%

Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
tapgarden/planter.go 2 74.87%
commitment/tap.go 6 83.91%
universe/interface.go 10 51.12%
Totals Coverage Status
Change from base Build 10924632032: 0.005%
Covered Lines: 24225
Relevant Lines: 59933

💛 - Coveralls

@gijswijs gijswijs self-requested a review September 19, 2024 12:46
@gijswijs
Copy link
Contributor

LGTM 🎉

@guggero guggero merged commit e3f531b into main Sep 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants