-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement]: Add universe-server configuration option to enable client access without authentication #390
Comments
I've created this PR which should achieve the desired behaviour. It doesn't yet include any new config flags. |
I feel like the right solution here is to add a
Or a config file. Do we have precedent for this in LND? @guggero ? |
I don't think we should do that, as users tend to shoot themselves in the foot with security related features like this. Macaroons are a bit tricky to handle, especially for new users. So if they see a way to disable authentication on all endpoints, they will do it, not being aware of the security implications. So I think we should only have a config option that is reasonably safe, for example |
Re-opening this whilst I'm working on a PR for adding |
Background
#367 requests to serve Universe stats with minimum prerequisites. E.g. Enable a universe server to respond to queries without requiring the client / user authenticate to the universe server:
As a
universe operator
I would like torespond to requests without requiring authentication from querying clients
in order tomake access to my service easily available without the need to identification / user friction
As a
universe operator
I would like torespond to requests without requiring authentication from querying clients
in order tonot require Terminal users to be logged in to query Universe stats
Deliverables
Add universe config flag to reduce the server's required client authentication for (QueryAssetStats and UniverseStats) gRPC calls
Relevant additions to list of RPCs will be made here:
taproot-assets/rpcperms/interceptor.go
Lines 98 to 105 in 7a5d5ca
which was delivered in commit 1660aa7
Consider a holistic design / more comprehensive set, of the configuration flags if other, unspecified-in-this-issue, calls or services might also benefit from not needing authentication.
Alternative solutions
Advantages:
Disadvantages:
The text was updated successfully, but these errors were encountered: