Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTLC_{SUCCESS,TIMEOUT}_INPUT_ANCHOR_WITNESS_WEIGHT are probably too high #3287

Open
TheBlueMatt opened this issue Sep 3, 2024 · 0 comments

Comments

@TheBlueMatt
Copy link
Collaborator

ANCHOR_INPUT_WITNESS_WEIGHT was too high by 2 (causing us to overpay fees by two weight units), and it was fixed in #3285 because a test required it. The HTLC constants are probably also wrong, but it shouldn't cause anything other than overpaying by two weight units per input, which isn't a huge deal. We should fix them, though, plus add a comment explaining how all three constants are calculated (the ANCHOR_INPUT_WITNESS_WEIGHT is 40 byte redeemscript, plus 71/72 bytes for a signature and 2 length bytes and a witness element count).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant