Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Sending ChannelUpdates in onion failures #3277

Open
TheBlueMatt opened this issue Aug 27, 2024 · 1 comment · May be fixed by #3345
Open

Stop Sending ChannelUpdates in onion failures #3277

TheBlueMatt opened this issue Aug 27, 2024 · 1 comment · May be fixed by #3345
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment

Comments

@TheBlueMatt
Copy link
Collaborator

These are optional now, and while other nodes might use them, they shouldn't do so for long (though lnd has said they'll keep using them, but only for fast-retires when they have stale feerate info, which I'm skeptical is common enough for us to care). Removing them would likely reduce a bunch of code.

@TheBlueMatt TheBlueMatt added the Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment label Aug 27, 2024
@vincenzopalazzo
Copy link
Contributor

Adding the PR link lightning/bolts#1173 just to make the problem clear. I was looking the code today but I was not able to remember where this change was made.

tankyleo added a commit to tankyleo/rust-lightning that referenced this issue Oct 1, 2024
@tankyleo tankyleo linked a pull request Oct 1, 2024 that will close this issue
tankyleo added a commit to tankyleo/rust-lightning that referenced this issue Oct 4, 2024
tankyleo added a commit to tankyleo/rust-lightning that referenced this issue Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants