Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rejecting duplicate offer payments #472

Open
TheBlueMatt opened this issue Feb 14, 2025 · 2 comments
Open

Support rejecting duplicate offer payments #472

TheBlueMatt opened this issue Feb 14, 2025 · 2 comments

Comments

@TheBlueMatt
Copy link

When using BOLT 12 to receive payments which are "single-use" (eg generating a unique offer for a merchant who wants to receive payment for an order once) ldk-node should support looking up the OfferId from the PaymentClaimable event and rejecting duplicate payments for an offer marked single-use, just like we can for BOLT 11 payments which are redundant.

@tnull
Copy link
Collaborator

tnull commented Feb 14, 2025

To do this properly (read: without having to iterate through all payments in the store), we probably want to wait until after #425.

@TheBlueMatt
Copy link
Author

I don't think there's a particular rush for this in the slightest. Anyone doing single-use invoices for quite a while is going to be using BOLT 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants