Skip to content

Commit cf92ff1

Browse files
committed
Check release build and make binding gen steps exit scripts
1 parent 6a1a1c9 commit cf92ff1

File tree

4 files changed

+19
-14
lines changed

4 files changed

+19
-14
lines changed

.github/workflows/build.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ jobs:
2222
profile: minimal
2323
- name: Build on Rust ${{ matrix.toolchain }}
2424
run: cargo build --verbose --color always
25-
- name: Check formatting
25+
- name: Check release build on Rust ${{ matrix.toolchain }}
26+
run: cargo check --release --verbose --color always
27+
- name: Check formatting on Rust ${{ matrix.toolchain }}
2628
if: matrix.check-fmt
2729
run: rustup component add rustfmt && cargo fmt --all -- --check
2830
- name: Test on Rust ${{ matrix.toolchain }}

scripts/uniffi_bindgen_generate.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
source ./scripts/uniffi_bindgen_generate_kotlin.sh
3-
source ./scripts/uniffi_bindgen_generate_python.sh
4-
source ./scripts/uniffi_bindgen_generate_swift.sh
2+
source ./scripts/uniffi_bindgen_generate_kotlin.sh || exit 1
3+
source ./scripts/uniffi_bindgen_generate_python.sh || exit 1
4+
source ./scripts/uniffi_bindgen_generate_swift.sh || exit 1
55

+11-8
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,18 @@
11
#!/bin/bash
2-
BINDINGS_DIR="./bindings/kotlin"
3-
TARGET_DIR="./target/bindings/kotlin"
2+
BINDINGS_DIR="bindings/kotlin"
3+
TARGET_DIR="target/bindings/kotlin"
44
PROJECT_DIR="ldk-node-jvm"
55
PACKAGE_DIR="org/lightningdevkit/ldknode"
66
UNIFFI_BINDGEN_BIN="cargo run --features=uniffi/cli --bin uniffi-bindgen"
77

8-
cargo build --target aarch64-apple-darwin
9-
$UNIFFI_BINDGEN_BIN generate bindings/ldk_node.udl --language kotlin -o "$TARGET_DIR"
8+
#rustup target add aarch64-apple-darwin
9+
#cargo build --target aarch64-apple-darwin || exit 1
10+
cargo build --release || exit 1
11+
$UNIFFI_BINDGEN_BIN generate bindings/ldk_node.udl --language kotlin -o "$TARGET_DIR" || exit 1
1012

11-
mkdir -p "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/kotlin/"$PACKAGE_DIR"
12-
mkdir -p "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/resources/darwin-aarch64/
13+
mkdir -p "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/kotlin/"$PACKAGE_DIR" || exit 1
14+
mkdir -p "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/resources/darwin-aarch64/ || exit 1
1315

14-
cp "$TARGET_DIR"/"$PACKAGE_DIR"/ldk_node.kt "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/kotlin/"$PACKAGE_DIR"/
15-
cp ./target/aarch64-apple-darwin/debug/libldk_node.dylib "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/resources/darwin-aarch64/libldk_node.dylib
16+
cp "$TARGET_DIR"/"$PACKAGE_DIR"/ldk_node.kt "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/kotlin/"$PACKAGE_DIR"/ || exit 1
17+
#cp ./target/aarch64-apple-darwin/debug/libldk_node.dylib "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/resources/darwin-aarch64/libldk_node.dylib || exit 1
18+
cp target/release/libldk_node.dylib "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/resources/libldk_node.dylib || exit 1

scripts/uniffi_bindgen_generate_swift.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
BINDINGS_DIR="./bindings/swift"
33
UNIFFI_BINDGEN_BIN="cargo run --features=uniffi/cli --bin uniffi-bindgen"
44

5-
cargo build --release
6-
$UNIFFI_BINDGEN_BIN generate bindings/ldk_node.udl --language swift -o "$BINDINGS_DIR"
5+
cargo build --release || exit 1
6+
$UNIFFI_BINDGEN_BIN generate bindings/ldk_node.udl --language swift -o "$BINDINGS_DIR" || exit 1
77

88
mkdir -p $BINDINGS_DIR
99

0 commit comments

Comments
 (0)