Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require node-fetch for browser targets #84

Open
AuHau opened this issue Sep 1, 2021 · 1 comment
Open

Do not require node-fetch for browser targets #84

AuHau opened this issue Sep 1, 2021 · 1 comment

Comments

@AuHau
Copy link

AuHau commented Sep 1, 2021

Currently, the library solely depends on node-fetch for providing fetch primitives like Header class and so on.

We plan to use it in the browser context, where these primitives are provided by the runtime and we would like to avoid packing node-fetch because of it. I would like to provide a similar abstraction that https://github.com/sindresorhus/ky-universal uses for NodeJS and browser, utilizing the browser property in package.json.

@mdlavin
Copy link
Member

mdlavin commented Sep 28, 2021

Seems reasonable to me. Go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants