Skip to content

Commit c5cad76

Browse files
committed
chore: review fixes
1 parent ffbb200 commit c5cad76

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

README.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,6 @@ In a typical weekly omnibus workflow, you need only `mainnet-fork` and
9999
`mainnet` networks. In case of large test campaign on Lido upgrades,
100100
it also could be useful to go with `holesky` and `holesky-fork` testnets first.
101101

102-
> [!IMPORTANT]
103-
> **Holesky specifics.**
104-
> Due to Holesky not being supported by Infura yet, setting RPC URL for Holesky is different. Instead of setting `WEB3_INFURA_PROJECT_ID` env variable set `HOLESKY_RPC_URL`.
105-
>
106-
> **Sepolia specifics.**
107-
> Due to Sepolia not being supported by Infura yet, setting RPC URL for Holesky is different. Instead of setting `WEB3_INFURA_PROJECT_ID` env variable set `SEPOLIA_RPC_URL`.
108-
109102
> [!WARNING]
110103
> **Holesky is partially supported.**
111104
> At the moment not all parameters are set in `configs/config_holesky.py` and acceptance/regression/snapshot tests are not operational.

network-config.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ live:
33
networks:
44
- chainid: 17000
55
explorer: https://api-holesky.etherscan.io/api
6-
host: $HOLESKY_RPC_URL
6+
host: https://holesky.infura.io/v3/$WEB3_INFURA_PROJECT_ID
77
id: holesky
88
# New backward-compatible multicall contract. multicall2 is missing on Holesky. See https://github.com/mds1/multicall
99
multicall2: "0xcA11bde05977b3631167028862bE2a173976CA11"
@@ -14,7 +14,7 @@ live:
1414
networks:
1515
- chainid: 11155111
1616
explorer: https://api-sepolia.etherscan.io/api
17-
host: $SEPOLIA_RPC_URL
17+
host: https://sepolia.infura.io/v3/$WEB3_INFURA_PROJECT_ID
1818
id: sepolia
1919
# New backward-compatible multicall contract. multicall2 is missing on Sepolia.
2020
# So multicall3 (backward compatible) is used. See https://github.com/mds1/multicall
@@ -50,35 +50,35 @@ development:
5050
port: 8545
5151
host: http://127.0.0.1
5252
id: goerli-fork
53-
name: goerli-fork
53+
name: Ganache-CLI (Goerli Fork)
5454
timeout: 360
5555

5656
# Holesky Fork
5757
- cmd: ./ganache.sh
5858
cmd_settings:
5959
accounts: 10
6060
chain_id: 17000
61-
fork: $HOLESKY_RPC_URL
61+
fork: holesky
6262
gas_limit: 30000000
6363
mnemonic: brownie
6464
port: 8545
6565
host: http://127.0.0.1
6666
id: holesky-fork
67-
name: holesky-fork
67+
name: Ganache-CLI (Holesky Fork)
6868
timeout: 360
6969

7070
# Sepolia Fork
7171
- cmd: ./ganache.sh
7272
cmd_settings:
7373
accounts: 10
7474
chain_id: 11155111
75-
fork: $SEPOLIA_RPC_URL
75+
fork: sepolia
7676
gas_limit: 30000000
7777
mnemonic: brownie
7878
port: 8545
7979
host: http://127.0.0.1
8080
id: sepolia-fork
81-
name: sepolia-fork
81+
name: Ganache-CLI (Sepolia Fork)
8282
timeout: 360
8383

8484
# Local Fork
@@ -92,7 +92,7 @@ development:
9292
port: 8545
9393
host: http://127.0.0.1
9494
id: local-fork
95-
name: local-fork
95+
name: Ganache-CLI (Local Fork)
9696
explorer: https://api.etherscan.io/api
9797
timeout: 360
9898
# https://github.com/mds1/multicall#multicall2-contract-addresses

0 commit comments

Comments
 (0)