-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sepolia deposit adapter implementation #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already have all the essentials, but there is some room for improvement.
Co-authored-by: Aleksei Potapkin <[email protected]>
Improve naming, remove logging, replace transfer() with call(), remove version, add error on call failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you for putting everything together!
I'd suggest one more round of refinements before declaring it as completed 🙏
Co-authored-by: Eugene Mamin <[email protected]>
Co-authored-by: Eugene Mamin <[email protected]>
Co-authored-by: Eugene Mamin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sepolia deposit adapter implementation + tests