Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sepolia deposit adapter implementation #821

Merged
merged 41 commits into from
Feb 21, 2024
Merged

Conversation

vp4242
Copy link
Member

@vp4242 vp4242 commented Feb 7, 2024

Sepolia deposit adapter implementation + tests

@vp4242 vp4242 changed the base branch from master to develop February 7, 2024 11:41
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already have all the essentials, but there is some room for improvement.

contracts/0.6.11/sepolia_deposit_contract.sol Outdated Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Fixed Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Outdated Show resolved Hide resolved
test/0.8.9/sepolia-deployment.test.js Outdated Show resolved Hide resolved
test/0.8.9/sepolia-deposit-adapter.test.js Outdated Show resolved Hide resolved
test/0.8.9/sepolia-deposit-adapter.test.js Outdated Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Outdated Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Outdated Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Outdated Show resolved Hide resolved
Co-authored-by: Aleksei Potapkin <[email protected]>
@vp4242 vp4242 marked this pull request as ready for review February 15, 2024 11:47
@vp4242 vp4242 marked this pull request as draft February 15, 2024 11:48
@vp4242 vp4242 marked this pull request as ready for review February 15, 2024 15:22
Improve naming, remove logging, replace transfer() with call(), remove version, add error on call failure
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for putting everything together!

I'd suggest one more round of refinements before declaring it as completed 🙏

contracts/0.8.9/SepoliaDepositAdapter.sol Outdated Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Outdated Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Show resolved Hide resolved
test/0.8.9/sepolia-deposit-adapter.test.js Outdated Show resolved Hide resolved
test/0.8.9/sepolia-deposit-adapter.test.js Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Show resolved Hide resolved
contracts/0.8.9/SepoliaDepositAdapter.sol Outdated Show resolved Hide resolved
@vp4242 vp4242 requested a review from TheDZhon February 20, 2024 16:57
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

contracts/0.8.9/SepoliaDepositAdapter.sol Show resolved Hide resolved
test/0.8.9/sepolia-deposit-adapter.test.js Show resolved Hide resolved
@TheDZhon TheDZhon merged commit c72ce19 into develop Feb 21, 2024
6 checks passed
@tamtamchik tamtamchik deleted the sepolia-deposit-adapter-impl branch September 30, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants