From c7a828ea8072de2768e2c1501378baf725ee4c99 Mon Sep 17 00:00:00 2001 From: DiRaiks Date: Thu, 23 May 2024 12:31:13 +0400 Subject: [PATCH 1/6] feat: add cron for ping IPFS gateway --- .github/workflows/cron-ping-ipfs.yml | 30 ++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 .github/workflows/cron-ping-ipfs.yml diff --git a/.github/workflows/cron-ping-ipfs.yml b/.github/workflows/cron-ping-ipfs.yml new file mode 100644 index 000000000..67f95551e --- /dev/null +++ b/.github/workflows/cron-ping-ipfs.yml @@ -0,0 +1,30 @@ +name: Cron ping IPFS Gateway + +on: + schedule: + - cron: '0 12 * * *' + workflow_dispatch: + inputs: + IPFS_CID: + description: 'IPFS CID' + required: true + type: string + GATEWAY: + description: 'Gateway' + required: true + type: string + +jobs: + build: + runs-on: ubuntu-latest + name: Ping IPFS Gateway + environment: Cron ping IPFS Gateway + steps: + - name: Ping IPFS Gateway + shell: bash + run: | + BODY_RESULT=`npx -y blumen@0.10.4 ping $IPFS_CID $GATEWAY` + echo "$BODY_RESULT" >> $GITHUB_STEP_SUMMARY + env: + IPFS_CID: ${{ inputs.IPFS_CID || vars.IPFS_CID }} + GATEWAY: ${{ inputs.GATEWAY || vars.GATEWAY }} From 8642aef2f43fa4303a4a9b3aca3e36e1f9678974 Mon Sep 17 00:00:00 2001 From: Evgeny Taktarov Date: Fri, 24 May 2024 17:40:23 +0700 Subject: [PATCH 2/6] fix: stake calldata marker for safe and ledger --- features/stake/stake-form/use-stake.ts | 36 ++++++++++---------------- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/features/stake/stake-form/use-stake.ts b/features/stake/stake-form/use-stake.ts index dd5a1e849..eddccb512 100644 --- a/features/stake/stake-form/use-stake.ts +++ b/features/stake/stake-form/use-stake.ts @@ -36,10 +36,9 @@ export const useStake = ({ onConfirm, onRetry }: StakeOptions) => { const { staticRpcProvider } = useCurrentStaticRpcProvider(); const { providerWeb3, providerRpc } = useSDK(); const { txModalStages } = useTxModalStagesStake(); - const { isLedgerLive, isLedger } = useConnectorInfo(); - // modifying calldata brakes clear sign - const shouldApplyCalldataSuffix = !isLedger && !isLedgerLive; + // modifying calldata brakes clear sign for LedgerLive + const shouldApplyCalldataSuffix = !useConnectorInfo().isLedgerLive; return useCallback( async ({ amount, referral }: StakeArguments): Promise => { @@ -67,37 +66,30 @@ export const useStake = ({ onConfirm, onRetry }: StakeOptions) => { ]); const callback = async () => { + const tx = await stethContractWeb3.populateTransaction.submit( + referralAddress, + { + value: amount, + }, + ); + + if (shouldApplyCalldataSuffix) applyCalldataSuffix(tx); + if (isMultisig) { - const tx = await stethContractWeb3.populateTransaction.submit( - referralAddress, - { - value: amount, - }, - ); return providerWeb3.getSigner().sendUncheckedTransaction(tx); } else { const { maxFeePerGas, maxPriorityFeePerGas } = await getFeeData(staticRpcProvider); - const overrides = { - value: amount, - maxPriorityFeePerGas, - maxFeePerGas, - }; - - const tx = await stethContractWeb3.populateTransaction.submit( - referralAddress, - overrides, - ); - if (shouldApplyCalldataSuffix) applyCalldataSuffix(tx); + tx.maxFeePerGas = maxFeePerGas; + tx.maxPriorityFeePerGas = maxPriorityFeePerGas; const originalGasLimit = await providerWeb3.estimateGas(tx); const gasLimit = applyGasLimitRatio(originalGasLimit); tx.gasLimit = gasLimit; - const signer = providerWeb3.getSigner(); - return signer.sendTransaction(tx); + return providerWeb3.getSigner().sendTransaction(tx); } }; From 0d60eae53a5897b98eb84e4547c784ca350a80f5 Mon Sep 17 00:00:00 2001 From: Taras Alekhin Date: Mon, 27 May 2024 13:43:17 +0200 Subject: [PATCH 3/6] docs: updated contributing doc --- CONTRIBUTING.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e1d063bdd..8f1800ef6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,11 +1,11 @@ ## Contributing Guidelines -Thank you for your interest in contributing to our project! We appreciate your enthusiasm and support. Currently, we are actively working on developing comprehensive contributing guidelines to ensure a smooth and collaborative contribution process. +Thank you for your interest in contributing to the project! Your enthusiasm and support are appreciated. Comprehensive contributing guidelines are actively being developed to ensure a smooth and collaborative contribution process. -**Note:** At this moment, we cannot guarantee that we will process pull requests or issues, as we are still establishing the workflow and guidelines that will make it easier for everyone to participate in the project. We understand the importance of community involvement and want to create an inclusive and comfortable environment for all contributors. +**Note:** At this moment, there is no guarantee that pull requests or issues will be processed, as the workflow and guidelines are still being established to make participation easier for everyone in the project. The importance of community involvement is understood, and an inclusive and comfortable environment for all contributors is being created. -Rest assured, as soon as the contributing guide is ready, we will be more than happy to welcome your contributions and address any issues you may encounter. We'll make an announcement when the guidelines are finalized and open for contributions. +Rest assured, as soon as the contributing guide is ready, contributions and any encountered issues will be welcomed and addressed. An announcement will be made when the guidelines are finalized and open for contributions. -In the meantime, we encourage you to explore the project, familiarize yourself with the codebase, and provide feedback or suggestions that will be valuable during this development phase. +In the meantime, exploring the project, familiarizing yourself with the codebase, and providing valuable feedback or suggestions during this development phase are encouraged. -Thank you for your patience and understanding. We look forward to your future contributions once the contributing guidelines are in place! +Thank you for your patience and understanding. Future contributions are eagerly anticipated once the contributing guidelines are in place! From 1d429a877aaf69a36fb2ece8c1eccb97e587b911 Mon Sep 17 00:00:00 2001 From: Taras Alekhin Date: Tue, 28 May 2024 11:50:33 +0200 Subject: [PATCH 4/6] docs: updated security doc --- SECURITY.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SECURITY.md b/SECURITY.md index 4a9c12531..41b6fa411 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -2,6 +2,6 @@ ### Reporting Security Vulnerabilities -Security is a top priority for our project. If you discover any security vulnerabilities or concerns, please responsibly disclose them through [Immunefi's bug bounty program](https://immunefi.com/bounty/lido/). +Security is a top priority for the project. If any security vulnerabilities or concerns are discovered, they should be responsibly disclosed through Immunefi's bug bounty program. -We value your efforts in helping us maintain a secure environment for all users. Thank you for your contribution to the project's safety. +Efforts in maintaining a secure environment for all users are highly valued. Thank you for your contribution to the project's safety. From 7ff3ef31d403d7667a5bd02f9caeeef2bc66d96e Mon Sep 17 00:00:00 2001 From: Taras Alekhin Date: Tue, 28 May 2024 11:53:40 +0200 Subject: [PATCH 5/6] docs: updated security doc --- SECURITY.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SECURITY.md b/SECURITY.md index 41b6fa411..d9fcc3bcb 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -2,6 +2,6 @@ ### Reporting Security Vulnerabilities -Security is a top priority for the project. If any security vulnerabilities or concerns are discovered, they should be responsibly disclosed through Immunefi's bug bounty program. +Security is a top priority for the project. If any security vulnerabilities or concerns are discovered, they should be responsibly disclosed through [Immunefi's bug bounty program](https://immunefi.com/bounty/lido/). Efforts in maintaining a secure environment for all users are highly valued. Thank you for your contribution to the project's safety. From 81dc92ede6bff355562abdad3eef9e0ea20dd751 Mon Sep 17 00:00:00 2001 From: DiRaiks Date: Wed, 29 May 2024 13:42:24 +0300 Subject: [PATCH 6/6] feat: update blumen version --- .github/workflows/cron-ping-ipfs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cron-ping-ipfs.yml b/.github/workflows/cron-ping-ipfs.yml index 67f95551e..b1831c9aa 100644 --- a/.github/workflows/cron-ping-ipfs.yml +++ b/.github/workflows/cron-ping-ipfs.yml @@ -23,7 +23,7 @@ jobs: - name: Ping IPFS Gateway shell: bash run: | - BODY_RESULT=`npx -y blumen@0.10.4 ping $IPFS_CID $GATEWAY` + BODY_RESULT=`npx -y blumen@0.10.11 ping $IPFS_CID $GATEWAY` echo "$BODY_RESULT" >> $GITHUB_STEP_SUMMARY env: IPFS_CID: ${{ inputs.IPFS_CID || vars.IPFS_CID }}