-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with official Deposit Contract #88
Comments
Actually, the current gas estimations include corrections for the difference between the real and mock deposit contracts in terms of gas costs (the mock one is much more costly). Also, we cannot hope to reproduce real deposit contract state that we’ll see in the full-scale testnet, so it’s more reliable to just use the numbers we see in the current deployed public contract instance, just like we’re doing right now. Nevertheless, integrating the real contract code is a good thing. But we should make sure that readability of the scenario tests doesn’t suffer as a result. |
Issue: lidofinance#88 Related issue: lidofinance#82 Add official deposit contract Update tests with deposit
…Limiter Feat: positive token rebase limiter fuzz tests
Now IValidatorRegistration interface and ValidatorRegistrationMock are synthetic. To prove compatibility with real-world environment, we should switch to official Ethereum 2 DepositContract and use it in all the test scenarios.
Note: Since there is a lot of math and costly operations (including iterative Merkle Tree walks) inside the real deposit call we can get new gas estimates and the numbers may depend on the Deposit contract state. Probably we'll need to test it at scale.
Related issue: #82
The text was updated successfully, but these errors were encountered: