Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with official Deposit Contract #88

Closed
ongrid opened this issue Oct 22, 2020 · 1 comment
Closed

Integration with official Deposit Contract #88

ongrid opened this issue Oct 22, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ongrid
Copy link
Contributor

ongrid commented Oct 22, 2020

Now IValidatorRegistration interface and ValidatorRegistrationMock are synthetic. To prove compatibility with real-world environment, we should switch to official Ethereum 2 DepositContract and use it in all the test scenarios.

Note: Since there is a lot of math and costly operations (including iterative Merkle Tree walks) inside the real deposit call we can get new gas estimates and the numbers may depend on the Deposit contract state. Probably we'll need to test it at scale.

Related issue: #82

@ongrid ongrid added the enhancement New feature or request label Oct 22, 2020
@ongrid ongrid added this to the RC2 milestone Oct 22, 2020
@ongrid ongrid self-assigned this Oct 22, 2020
@skozin
Copy link
Member

skozin commented Oct 22, 2020

Actually, the current gas estimations include corrections for the difference between the real and mock deposit contracts in terms of gas costs (the mock one is much more costly). Also, we cannot hope to reproduce real deposit contract state that we’ll see in the full-scale testnet, so it’s more reliable to just use the numbers we see in the current deployed public contract instance, just like we’re doing right now.

Nevertheless, integrating the real contract code is a good thing. But we should make sure that readability of the scenario tests doesn’t suffer as a result.

@ongrid ongrid assigned Klyaus and unassigned ongrid Oct 23, 2020
Klyaus added a commit that referenced this issue Oct 23, 2020
Issue: #88
Related issue: #82

Add official deposit contract
Update tests with deposit
ongrid pushed a commit that referenced this issue Oct 26, 2020
Issue: #88
Related issue: #82

Add official deposit contract
Update tests with deposit
@ongrid ongrid closed this as completed Oct 28, 2020
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
Issue: lidofinance#88
Related issue: lidofinance#82

Add official deposit contract
Update tests with deposit
tamtamchik pushed a commit that referenced this issue Sep 30, 2024
…Limiter

Feat: positive token rebase limiter fuzz tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants