Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: hardhat tooling improvements #32

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Feat: hardhat tooling improvements #32

merged 4 commits into from
Feb 21, 2024

Conversation

TheDZhon
Copy link
Contributor

Add some helpful hardhat plugins 💪

  • Add contract sizer
  • Add ignore warnings
  • Bump dependency versions

Addresses #28

@TheDZhon TheDZhon linked an issue Feb 20, 2024 that may be closed by this pull request
Bulky non-relevant solidity warnings #28
Open
@github-actions GitHub Actions
Copy link

🧪 Test coverage: 18.17%

Code Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ----------------------------------------------
contracts/0.4.24/Lido.sol                                        212     102  51.89%   587-589, 683-722, 809-909, 970-1077, 1181-1361
contracts/0.4.24/StETH.sol                                        72      20  72.22%   287-294, 331-360, 492-506
contracts/0.4.24/StETHPermit.sol                                  15       2  86.67%   130-149
contracts/0.4.24/lib/Packed64x4.sol                                5       5  0.00%    26-47
contracts/0.4.24/lib/SigningKeys.sol                              36      36  0.00%    25-177
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   485     485  0.00%    208-1450
contracts/0.4.24/oracle/LegacyOracle.sol                          72      72  0.00%    114-399
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17      11  35.29%   70-116
contracts/0.8.9/BeaconChainDepositor.sol                          21      19  9.52%    47-88
contracts/0.8.9/Burner.sol                                        71      71  0.00%    140-380
contracts/0.8.9/DepositSecurityModule.sol                        104       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       1  93.75%   75
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16      16  0.00%    64-121
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28      28  0.00%    16-73
contracts/0.8.9/StakingRouter.sol                                303     296  2.31%    157-1318
contracts/0.8.9/WithdrawalQueue.sol                               88      74  15.91%   89-116, 148-370, 384-392, 397, 400-413
contracts/0.8.9/WithdrawalQueueBase.sol                          146     129  11.64%   123-353, 394-542, 556-557, 582-594
contracts/0.8.9/WithdrawalQueueERC721.sol                         89      30  66.29%   110-159, 213, 244, 270, 273, 332, 351-392
contracts/0.8.9/WithdrawalVault.sol                               21      21  0.00%    56-123
contracts/0.8.9/lib/Math.sol                                       4       4  0.00%    9-29
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22      22  0.00%    88-172
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/lib/UnstructuredStorage.sol                        8       4  50.00%   13-21, 29
contracts/0.8.9/oracle/AccountingOracle.sol                      171     171  0.00%    153-881
contracts/0.8.9/oracle/BaseOracle.sol                             89      89  0.00%    104-410
contracts/0.8.9/oracle/HashConsensus.sol                         263     263  0.00%    249-1094
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17      16  5.88%    29-87
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      171     171  0.00%    156-791
contracts/0.8.9/utils/PausableUntil.sol                           31      29  6.45%    28-40, 46, 60-100
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23      15  34.78%   80-81, 106-174, 205-207, 228-230
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       4  55.56%   51-59, 74-75
contracts/common/lib/ECDSA.sol                                     8       0  100.00%
contracts/common/lib/Math256.sol                                   6       6  0.00%    13-42
contracts/common/lib/MemUtils.sol                                  8       8  0.00%    14-64
contracts/common/lib/MinFirstAllocationStrategy.sol               27      27  0.00%    35-105
contracts/common/lib/SignatureUtils.sol                           10       0  100.00%
TOTAL                                                           2857    2338  18.17%

Diff against master

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: e3214c6

Minimum allowed coverage is 0%

♻️ This comment has been updated with latest results

tamtamchik
tamtamchik approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@tamtamchik tamtamchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@TheDZhon TheDZhon merged commit 5890112 into develop Feb 21, 2024
5 checks passed
@tamtamchik tamtamchik deleted the feat/hardhat-tooling-improvements branch February 21, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamtamchik tamtamchik tamtamchik approved these changes

@mymphe mymphe mymphe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bulky non-relevant solidity warnings
3 participants
@TheDZhon @tamtamchik @mymphe