Bond balance getting lower on 1 or 2 wei due to rounding down integer math after deposit

[vgorkavenko]

The root of the problem is described here lidofinance/lido-dao#442

It affects the flows described below

ETH\stETH deposit

• Node operator's manager deposits bond in ETH\stETH with 1 validator key
• CSMAccounting stakes\transfer (depends on token) this amount and increases Node operator's bond with resulting shares
• Node operator's manager checks for the required bond for the already added key by corresponding contract method and expects to get 0 Wei in ETH\stETH

Current behavior: The contract gives 1 Wei because the conversion from shares to ethers include rounding error and it is reflected in diff between required bond and the current NO bone

wstETH deposit

• Node operator's manager deposits bond in wstETH with 1 validator key
• CSMAccounting unwrap this amount to stETH and increases Node operator's bond with resulting shares
• Node operator's manager checks for the required bond for the already added key by corresponding contract method and expects to get 0 Wei in ETH\stETH\wstETH

Current behavior: The contract gives 2 Wei (includes rounding error after wstETH unwrapping on deposit) because the conversion from shares to ethers include rounding error and it is reflected in diff between required bond and the current NO bone

Current mitigation

Method returning the required bond value for the next key(s) to deposit takes into account the missing Wei

[dgusakov]

🍌 valid issue. Yet, I suppose it should be fixed on the stETH side. Anyway, thanks for pointing it out!