-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Changing GateSeal address #535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the effort and changed brought!
Left some nitpicks and questions here and there.
Have only a single consideration about old instance tests — is it worth doing it this way comparing with #532?
const EXITBUS_ORACLE_ADDRESS: string = '0x0de4ea0184c2ad0baca7183356aea5b8d5bf5c6e' | ||
const GATE_SEAL_FACTORY_ADDRESS: string = '0x6c82877cac5a7a739f16ca0a89c0a328b8764a24' | ||
const WITHDRAWALS_VAULT_ADDRESS: string = '0xb9d7934878b5fb9610b3fe8a5e441e8fad7e293f' | ||
const EL_REWARDS_VAULT_ADDRESS: string = '0x388c818ca8b9251b393131c08a736a67ccb19297' | ||
|
||
// const for backward functional test capability | ||
// https://github.com/lidofinance/alerting-forta/issues/533 | ||
export const GATE_SEAL_DEFAULT_ADDRESS_BEFORE_26_APR_2024: string = '0x1ad5cb2955940f998081c1ef5f5f00875431aa90' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that we should store this constant tbh
I mean, the approach used in #532 was less intrusive for the codebase and less verbose 🤔
I am just wondering how we would shape the tests for the GateSeal expiration alerts :) |
6325eb9
to
64d70d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.