Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ongoing games hidden for new users #1404

Open
Carlme96 opened this issue Feb 3, 2025 · 2 comments
Open

Ongoing games hidden for new users #1404

Carlme96 opened this issue Feb 3, 2025 · 2 comments
Labels
bug Something isn't working cat: game All things related to playing a game good first issue Good for newcomers
Milestone

Comments

@Carlme96
Copy link

Carlme96 commented Feb 3, 2025

What is the problem?

If an account has not finished any games, then the "games in play" and "Recent games" sections of the app is hidden. There will be no way to open e.g. an ongoing correspondence game through the app if the account has not finished any other games.

What happened
I invited someone who has never played on Lichess before (had to use Lichess Beta since the old app was not compatible with their phone). They made a new account, and then we started a correspondence game with 14 days move time. After exiting the app, they could not find the ongoing game anywhere in the app. "Games in play" and "Recent games" is missing.

It was only after finishing another short game, that they could find our game again.

Expected behaviour
If an account has not played any games, but is in the middle of one, "games in play" should show as normal. Only "Recent games" should be hidden.

Steps to reproduce the bug

  1. Create a new account
  2. Start a correspondence match with someone. Do not finish it.
  3. Exit the app
  4. Open the app. Find that "Games in play" and "Recent games" are missing.
  5. Start any match, for example by using Quick Pairing, and finish it such that you have at least one finished game.
  6. "Games in play" will appear.

App version

0.13.13

Device Info

Samsung Galaxy S24 / Android 14

Additional information

No response

@Carlme96 Carlme96 added the bug Something isn't working label Feb 3, 2025
@Carlme96
Copy link
Author

Carlme96 commented Feb 3, 2025

I suspect this code is to blame, as it seems to only load ongoing games when not having an empty recent.

final widgets =
emptyRecent
? _welcomeScreenWidgets(session: session, status: status, isTablet: isTablet)
: isTablet
? _tabletWidgets(
session: session,
status: status,
ongoingGames: ongoingGames,
recentGames: recentGames,
nbOfGames: nbOfGames,
)
: _handsetWidgets(
session: session,
status: status,
ongoingGames: ongoingGames,
recentGames: recentGames,
nbOfGames: nbOfGames,
);

@tom-anders tom-anders added good first issue Good for newcomers cat: game All things related to playing a game labels Feb 4, 2025
@veloce veloce added this to the Public beta milestone Feb 5, 2025
@veloce
Copy link
Contributor

veloce commented Feb 5, 2025

Thanks for this report. Will fix asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cat: game All things related to playing a game good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

3 participants