libvirt_domain_attach_device() in v0.8.1 unexpectedly calls virDomainAttachDevice instead of virDomainAttachDeviceFlags

[mrc0mmand]

As described in [0], libvirt_domain_attach_device() in v0.8.1 calls virDomainAttachDevice when flags == 0, which doesn't work when the target domain isn't active, whereas calling virDomainAttachDeviceFlags works even on inactive domains . This was changed in [1] and seems to be an unfortunate design flaw [2], where virDomainAttachDeviceFlags(0) != virDomainAttachDevice. Similarly for virDomainDetachDeviceFlags and virDomainDettachDevice.

[0] vagrant-libvirt/vagrant-libvirt#1800
[1] 798c0ca
[2] vagrant-libvirt/vagrant-libvirt#1800 (comment)

[github-actions]

Thank you for your interest in the libvirt project.

Since this repository is a read-only mirror of the project's master
repostory hosted on GitLab, issues opened here are not processed.

We kindly request that new issues are reported to

https://gitlab.com/libvirt/libvirt-ruby/-/issues/new

Thank you for your time and understanding.