Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the Xcode project needs updating #394

Open
sezero opened this issue Oct 16, 2023 · 1 comment
Open

the Xcode project needs updating #394

sezero opened this issue Oct 16, 2023 · 1 comment
Assignees

Comments

@sezero
Copy link
Contributor

sezero commented Oct 16, 2023

Xcode project needs updating for both SDL2 and SDL3 branches:

  • avif: vendored libavif has been updated to 1.0.1: the project must
    be updated to reflect that.

  • dav1d: vendored dav1d has been updated to 1.2.1: the project must be
    updated to reflect that.

Additional notes about existing Xcode dav1d project in SDL_image:

  • STACK_ALIGNMENT is defined only for x86_64 config but not arm
    configs: Intentional?? (Same goes for the Android configs in
    vendored dav1d itself.)

  • STACK_ALIGNMENT is defined as 32: is that deliberately picked?
    Because meson build systems defines it either as 4 or 16 unless
    user-specified. (Same goes for the Android configs in vendored
    dav1d itself.)

  • There is no config.asm in none of the configs. (Same goes for
    the Android configs in vendored dav1d itself.)

    • Only for Android configs in vendored dav1d itself: PREFIX is
      defined in all configs: Is that accurate, or some copy/paste
      artifact from Xcode configs in SDL_image? (I guess the latter?)

A job for @slouken (can't do myself.)

@sezero sezero added this to the 2.8.0 milestone Oct 16, 2023
@slouken slouken removed this from the 2.8.0 milestone Nov 29, 2023
@slouken
Copy link
Collaborator

slouken commented Nov 29, 2023

I don't know the answers to these questions, but I verified that the avif loader works on macOS. I'll go ahead and leave this open for now, in case someone runs into problems with the current settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants