Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save function in RetroArch not enabled #32

Open
Kupo91 opened this issue Dec 2, 2018 · 3 comments
Open

Save function in RetroArch not enabled #32

Kupo91 opened this issue Dec 2, 2018 · 3 comments

Comments

@Kupo91
Copy link

Kupo91 commented Dec 2, 2018

Name of the game: Vampires Dawn

Player platform: Linux (LibreElec)

Describe the issue in detail and how to reproduce it: Usually all cores in RetroArch have a save function. Atleast all cores which I've tested so far. However in RetroArch easyrpg you get an error message like "This core doesn't support this function" or something like that.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Ghabry
Copy link
Collaborator

Ghabry commented Dec 2, 2018

Well the problem is here that EasyRPG Player, compared to almost anything else in RetroArch, is a game engine and not an emulator.

Savestates are really tricky for these because you must serialize all the game data which is a gigantic afford for little gain.
For emulators you can "simply" dump the memory map and the register of the virtual CPU and you are done.

@Ghabry
Copy link
Collaborator

Ghabry commented Apr 15, 2019

Actually supporting that save option would be possible with some restrictions.
I could just hook it to the normal Save function which means the saving will fail when not on the map and in some situations on the map it will not properly save.

Could hide it behind a core option.

@Ghabry
Copy link
Collaborator

Ghabry commented Apr 16, 2019

I will keep this disabled.

Arbitrary save and load, even on the map, doesn't really work currently without crashing because our code is just not designed for it and this use case was never tested (especially load is broken).
For now I recommend using the Debug mode through the core options and then save via the debug scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants