-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPORTANT] Documented that input_vendor_id
, and input_product_id
are used by udev
#16904
Comments
# Remove input_vendor_id and input_product_id once this issue has been solved: [IMPORTANT] Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904 input_vendor_id = "1356" input_product_id = "2508"
# Remove input_vendor_id and input_product_id once this issue has been solved: [IMPORTANT] Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904 input_vendor_id = "1406" input_product_id = "8201"
# Remove input_vendor_id and input_product_id once this issue has been solved: [IMPORTANT] Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904 input_vendor_id = "1406" input_product_id = "8201"
# Remove input_vendor_id and input_product_id once this issue has been solved: [IMPORTANT] Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904 input_vendor_id = "1356" input_product_id = "3302"
input_vendor_id
, and input_product_id
in autoconfig files generated by udev
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
…Controller (default-off).cfg The individual responsible for uploading the file inadvertently swapped the non-HID autoconfig file with the HID autoconfig file. You can access the non-HID file [here](libretro@3abfcb2) and the HID file [here](libretro@3abfcb2). To address this issue, I: * Removed "(old)" from the non-HID file and added "(default-off)" to the HID file to align with our updated naming convention. * Swapped their autoconfig data. However, he was correct about one detail. He included `input_device = "Pro Controller"` (Bluetooth identifier name), which I mistakenly later changed to `input_device = "Nintendo Co., Ltd. Pro Controller"` (USB identifier name) ([source](libretro@98b1591)). The non-HID driver does not support USB connection for this controller, only Bluetooth. I made this change because I believed the udev controller driver identified the controller using `input_vendor_id` / `input_product_id`, as generated by "Save Controller Profile" in RetroArch, but later discovered that udev relies on `input_device`, which led me to file a bug report. Consequently, I edited this file: * I removed the commented variables `input_product_id` and `input_vendor_id` which fail to disable this controller. * Commented `input_device = Pro Controller` to disable this controller to leave file name space for `Pro Controller.cfg` (HID) since Linux 6.8.0 (Ubuntu 24.04) also identifies this controller as "Pro Controller". I filed this issue just a few days ago: * [GitHub Issue](libretro/RetroArch#16904) Additionally, I removed the comments as a standard procedure. "non-HID" is included in `input_device_display_name`.
Hello, I'd like to ask about this statement: RetroArch/input/drivers_joypad/udev_joypad.c Line 211 in 585e70e
and RetroArch/input/drivers_joypad/udev_joypad.c Line 279 in 585e70e
|
Could you please review and confirm the following steps?
I am curious about what the code does in the lines you mentioned. If input_vendor_id and input_product_id are essential, we should include this information in our joypad user guide by adding something like : The udev controller uses the input_device as well as input_vendor_id/input_product_id. input_device is used to identify and connect the controller, and the input_vendor_id and input_product_id variables are used for [arguments]. |
Doing the above, I get the following with my controller:
All in all, it works according to the affinity rules: RetroArch/tasks/task_autodetect.c Line 104 in 329b16d
|
|
…ition.cfg to Sony Dualshock 4 Wireless - 500 Million Limited Edition (default-off).cfg Solved: libretro/RetroArch#16904
Thank you very much for taking the time to assist Zoltanvb! |
input_vendor_id
, and input_product_id
in autoconfig files generated by udevinput_vendor_id
, and input_product_id
are used by udev
input_vendor_id
, and input_product_id
are used by udevinput_vendor_id
, and input_product_id
are used by udev
Description
Until this issue has been solved it will be impossible to duplicate files and modify the input_device, to make controllers compatible with linuxraw, or udev for with multiple Linux kernel versions, or BlueTooth/USB:
In RetroArch, the linuxraw and udev drivers rely on input_device instead of input_vendor_id and input_product_id. These drivers automatically select the autoconfig file that matches the name used by the active Linux kernel.
However, when using udev, RetroArch still generates input_vendor_id and input_product_id, even though they aren't necessary. This behavior is not present in linuxraw. The issue with udev creates the impression that users need to comment or uncomment these IDs to choose which udev autoconfig file to use, especially when multiple autoconfig files are available—a common scenario for both non-HID and HID autoconfig files.
Expected behavior
The configuration should be as follows:
Also, input_driver and input_device should not be required by PR checks for udev (they are not required by linuxraw)
Actual behavior
udev: The configuration currently includes unnecessary vendor and product IDs:
linuxraw
Steps to reproduce the bug
Todo list
After resolving the issue, please remove input_driver and input_device from the following autoconfig files that I am maintaining:
Newly created PRs that can be used to diagnose this issue:
Sony Interactive Entertainment DualSense Wireless Controller.cfg
retroarch-joypad-autoconfig#1140Nintendo Co., Ltd. Pro Controller.cfg
toNintendo Switch Pro Controller
retroarch-joypad-autoconfig#1186Version/Commit
The text was updated successfully, but these errors were encountered: